Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updated test-domain-exit-dispose-again #10003

Closed
wants to merge 1 commit into from
Closed

test: updated test-domain-exit-dispose-again #10003

wants to merge 1 commit into from

Conversation

Ethan-Arrowood
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

setTimeout at 49:5 requires two arguments, so I added
TIMEOUT_DURATION as the second argument. On lines 72
and 73 changed assert.equal() to assert.strictEqual().

setTimeout at 49:5 requires two arguments, so I added
TIMEOUT_DURATION as the second argument. On lines 72
and 73 changed assert.equal() to assert.strictEqual().
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added the domain Issues and PRs related to the domain subsystem. label Dec 1, 2016
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott
Copy link
Member

Trott commented Dec 7, 2016

CI failures are unrelated.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout duration for a timer that should never run should be set to the minimum IMO, which is 1.

@@ -51,7 +51,7 @@ setTimeout(function firstTimer() {
'a domain that should be disposed.');
disposalFailed = true;
process.exit(1);
});
}, TIMEOUT_DURATION);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 1 instead of TIMEOUT_DURATION.

@Trott
Copy link
Member

Trott commented Dec 7, 2016

Landing. Will fix the one nit while doing so.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 7, 2016
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: nodejs#10003
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 7, 2016

Landed in ac78812.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 7, 2016
addaleax pushed a commit that referenced this pull request Dec 8, 2016
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: nodejs#10003
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants