Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use const or let and assert.strictEqual #10001

Closed
wants to merge 1 commit into from
Closed

test: use const or let and assert.strictEqual #10001

wants to merge 1 commit into from

Conversation

crokita
Copy link
Contributor

@crokita crokita commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX)
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Change assert.equal() to assert.strictEqual(), change var to const in require statements and change i in for loop to let

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
mhdawson
mhdawson approved these changes Dec 3, 2016
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016 •
edited
Loading

CI run: https://ci.nodejs.org/job/node-test-pull-request/5218/

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016

Failure on freebsd is a different test and not related. Opened: #10130 to track it separately.

@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Landed in 8a3c7d7. Thank you for the PR and for participating in the code-and-learn

@jasnell jasnell closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@crokita @Fishrock123
test: use const or let and assert.strictEqual
fdc55ef 
PR-URL: #10001
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@crokita @addaleax
test: use const or let and assert.strictEqual
a609604 
PR-URL: nodejs#10001
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@crokita
test: use const or let and assert.strictEqual
a3e422b 
PR-URL: nodejs#10001
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@crokita @MylesBorins
test: use const or let and assert.strictEqual
3f9d75c 
PR-URL: #10001
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@crokita @MylesBorins
test: use const or let and assert.strictEqual
cd55d43 
PR-URL: #10001
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@crokita @MylesBorins
test: use const or let and assert.strictEqual
9e60d63 
PR-URL: #10001
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@crokita @mhdawson @jasnell @cjihrig @mscdex @MylesBorins @addaleax @imyller @nodejs-github-bot