Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffers: copy-on-destroy concept #997

Closed
indutny opened this issue Feb 28, 2015 · 4 comments
Closed

buffers: copy-on-destroy concept #997

indutny opened this issue Feb 28, 2015 · 4 comments
Assignees
@indutny
Labels
buffer Issues and PRs related to the buffer subsystem.

Comments

@indutny
Copy link
Member

indutny commented Feb 28, 2015

n/t

cc @domenic
@indutny indutny self-assigned this Feb 28, 2015
@indutny
Copy link
Member Author

indutny commented Feb 28, 2015

I wish we could detect the cases where the buffer passed to _handle.ondata won't be alive or referenced after the invocation.

@brendanashworth brendanashworth added the buffer Issues and PRs related to the buffer subsystem. label Mar 7, 2015
@Fishrock123
Copy link
Contributor

@indutny / @trevnorris any idea if this is possible with the new TypedArray-backed buffers?

@indutny
Copy link
Member Author

indutny commented Jul 16, 2015

Thinking of it, I don't see a use for it anymore. @trevnorris if you don't have any ideas either, let's kill this issue.

@trevnorris
Copy link
Contributor

Don't have any other ideas.

MylesBorins pushed a commit that referenced this issue Dec 20, 2016
@cByst @MylesBorins
test: assert.throws() should include a RegExp
a090899 
PR-URL: #997
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Dec 21, 2016
@cByst @MylesBorins
test: assert.throws() should include a RegExp
c2bc38f 
PR-URL: #997
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this issue Dec 21, 2016
Merged
@pdkovacs pdkovacs mentioned this issue Jun 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indutny indutny

Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@indutny @trevnorris @Fishrock123 @brendanashworth