Release proposal: v1.4.2 #995

rvagg · 2015-02-27T23:32:22Z

This is a quick one, will give it 24 hours or less. Mainly to fix #988, proposed change being in #994.

[25da0742ee] - build: improve vcbuild.bat (Bert Belder) #998
[b8310cbd3e] - build: reduce tarball size by 8-10% (Johan Bergström) #961
[58a612ea9d] - deps: make node-gyp work with io.js (cjihrig) #990
[2a2fe5c4f2] - deps: upgrade npm to 2.6.1 (Forrest L Norvell) #990
[84ee2722a3] - doc: minor formatting fixes. (Tim Oxley) #996
[cf0306cd71] - doc: update stability index (Chris Dickinson) #943
[fb2439a699] - doc: add robertkowalski as collaborator (Robert Kowalski) #977
[f83d380647] - doc: update os.markdown (Benjamin Gruenbaum) #976
[ae7a23351f] - doc: add roadmap, i18n, tracing, evangelism WGs (Mikeal Rogers) #911
[14174a95a5] - doc: document roadmap, workgroups (Mikeal Rogers)
[865ee313cf] - doc: add tellnes as collaborator (Christian Tellnes) #973
[01296923db] - doc: add mscdex as collaborator (Brian White) #972
[675cffb33e] - http: don't confuse automatic headers for others (Christian Tellnes) #828
[7887e119ed] - install: new performance counters provider guid (Russell Dempsey)
[4d1fa2ca97] - src: add check for already defined macro NOMINMAX (Pavel Medvedev) #986
[1ab7e80838] - tls: proxy handle.reading back to parent handle (Fedor Indutny) #1004
[755461219d] - tls: fix typo handle._reading => handle.reading (Fedor Indutny) #994

The text was updated successfully, but these errors were encountered:

rvagg · 2015-02-27T23:34:07Z

FYI: Jenkins is being a for us and getting different build machines to build on different commits, hiding test failures that crept in before 1.4.1. I also had lots of trouble even getting 1.4.1 out because of this but I think I may have sorted it out (never say never with Jenkins).

CI on v1.x as it is now: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/207/ - expecting to see Windows failures this time. Will try #994 next.

rvagg · 2015-02-27T23:42:00Z

And there it is! Human error after all, the test-ci and introduction of TAP changes in CI were causing havoc so I'd reverted the test runs to be just test-simple and test-message but only test-message is running on Windows. I'm not actually sure why since it's doing vcbuild.bat release nosign x64 test-simple test-message and that's supposed to work. Trying just vcbuild.bat release nosign x64 test now.

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/208/

indutny · 2015-02-28T00:04:41Z

Yay! :)

rvagg · 2015-02-28T00:19:08Z

2015-02-28, Version 1.4.2, @rvagg

Notable changes

tls: A typo introduced in the TLSWrap changes in #840 only encountered as a bug on Windows was not caught by the io.js CI system due to problems with the Windows build script and the Windows CI slave configuration. Fixed in #994 & #1004. (Fedor Indutny)
npm: Upgrade npm to 2.6.1. See npm CHANGELOG.md for details. Summary:
- 8b98f0e
  #4471 npm outdated (and only npm outdated) now defaults to --depth=0. This also has the excellent but unexpected effect of making npm update -g work the way almost everyone wants it to. See the docs for
  --depth
  for the mildly confusing details. (@smikes)
- aa79194
  #6565 Tweak peerDependency
  deprecation warning to include which peer dependency on which package is
  going to need to change. (@othiym23)
- 5fa067f
  #7171 Tweak engineStrict
  deprecation warning to include which package.json is using it.
  (@othiym23)
Add new collaborators:
- Robert Kowalski (@robertkowalski)
- Christian Vaagland Tellnes (@tellnes)
- Brian White (@mscdex)

Known issues

Windows support has some outstanding failures that have not been properly picked up by the io.js CI system due to a combination of factors including human, program and Jenkins errors. See #1005 for details & discussion. Expect these problems to be addressed ASAP.
Surrogate pair in REPL can freeze terminal #690
Not possible to build io.js as a static library #686
process.send() is not synchronous as the docs suggest, a regression introduced in 1.0.2, see #760 and fix in #774
Calling dns.setServers() while a DNS query is in progress can cause the process to crash on a failed assertion #894

Commits

rvagg · 2015-02-28T00:20:02Z

I might just do this today, give me a few hours to work on Jenkins to make sure it's working properly and I'll go ahead and do a release.

PLEASE DON'T INTRODUCE SEMVER-MINOR COMMITS UNTIL THIS IS RELEASED

rvagg · 2015-02-28T00:32:31Z

@indutny @piscisaureus the real problem atm is that Jenkins isn't getting a !0 exit code from vcbuild. Check this out: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/209/nodes=iojs-win2012r2/console - note the SUCCESS at the bottom but 79 errors. So it's always going to be blue. Any clues what that might be about? Full command on this is this atm: vcbuild.bat release nosign x64 test.

piscisaureus · 2015-02-28T00:50:11Z

@rvagg

Check this out: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/209/nodes=iojs-win2012r2/console -

But these look like genuine failures. Or am I missing something?

rvagg · 2015-02-28T00:52:25Z

@piscisaureus genuine failures but the build is blue (not red), look at the last line:

Finished: SUCCESS

It's not reporting back. I'm about to hop on one of these machines and investigate whether it's the use of -J for test.py that's doing this (current theory), if you have any better ideas then let me know. Basically with the current test setup we can have failures on Windows that you won't see unless you're looking at console output.

piscisaureus · 2015-02-28T01:04:03Z

@rvagg I'm guessing that the exit code is zero because after the tests, jslint runs and succeds.

Batch processing isn't aborted when a command returns a nonzero exit code, So even if there are test failures, the jslint step will run after that and set the exit code to 0.

rvagg · 2015-02-28T01:07:24Z

@piscisaureus also vcbuild.bat release nosign x64 test-simple test-message only runs test-message and I don't understand why.

piscisaureus · 2015-02-28T01:12:43Z

@piscisaureus also vcbuild.bat release nosign x64 test-simple test-message only runs test-message and I don't understand why.

Huh, do you have a jenkins link? vcbuild.bat looks like it does the right thing.

rvagg · 2015-02-28T01:15:13Z

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/200/nodes=iojs-win2012r2/console for instance was run with that string. I'm also on one of the servers now running it myself and get the same behaviour. As if test-simple is completely ignored as an argument. Switch them around and it seems to work (although tbh I can't tell just at the moment if test-message is being run or not after test-simple).

piscisaureus · 2015-02-28T01:20:55Z

@rvagg oops. vcbuild.bat is the culprit:

https://github.com/iojs/io.js/blob/v1.x/vcbuild.bat#L59

piscisaureus · 2015-02-28T01:43:51Z

@rvagg #998

rvagg · 2015-02-28T06:35:50Z

RC https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/93/

Bound for https://iojs.org/download/nightly/v1.4.2-nightly20150228755461219d/

rvagg · 2015-02-28T06:58:21Z

confirmed that #988 is fixed in the above nightly build, just doing another CI run because I'm still not happy that vcbuild is fixed, and then will move on to a release if all's good.

rvagg · 2015-02-28T07:08:52Z

No good, https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/212/ is not happy on Windows.

@indutny, you have some work to do, sorry: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/212/nodes=iojs-win2008r2/console & https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/212/nodes=iojs-win2012r2/console - 12 failures on both Windows machines, seem to be focused on tls_wrap.

1.4.2 is going to have to wait some more.

indutny · 2015-02-28T18:18:02Z

@rvagg many tests are using curl without checking for platform...

indutny · 2015-02-28T18:20:37Z

Ah, I see that it is a pre-requisite...

Fix: nodejs#995

indutny · 2015-02-28T18:31:18Z

Leaves it with 3 failures for me #1003

indutny · 2015-02-28T18:32:24Z

test-stdin-from-file
test-fs-access
test-child-process-stdio-big-write-end

The latter one seems to be triggering some ENOTSUP on writev... @piscisaureus ?

piscisaureus · 2015-02-28T18:46:12Z

@indutny libuv-windows doesn't support writev on named and ipc pipes, and will fail with ENOTSUP. Maybe that's causing the failures?

rvagg · 2015-02-28T19:03:40Z

@piscisaureus I really need to get a release out to deal with the tls-wrap bug, can you give me an assessment of whether it's worth holding it up to deal with these too? If not, then a "Known issues" item would be good but I don't know what that should be; something about "ENOTSUP on writev errors on Windows"

Fix: nodejs#995

piscisaureus · 2015-02-28T21:37:14Z

@rvagg

To be honest I think that the test-child-process-stdio-big-write-end failure is very serious. I can't trivially implement writev() for pipes in libuv, so I would suggest reverting the StreamBase patches for the time being.

piscisaureus · 2015-02-28T21:39:02Z

I'm sorry, I don't have an opportunity today to find a better solution ...
Maybe we can change the "current version" on the website back to 1.3.x ?

indutny · 2015-02-28T21:39:02Z

@piscisaureus I doubt it is related to StreamBase.

indutny · 2015-02-28T21:40:13Z

@piscisaureus Aaaah, I think you actually talked about StreamWrap::AddMethods...

rvagg · 2015-02-28T21:40:29Z

@piscisaureus @indutny I have a 1.4.2 built and ready to release and seems to address most of the concerns related to tls, should I just push this out while we find a way to fix things up for a 1.4.3? That's my vote but I really don't understand the details of the other problems.

indutny · 2015-02-28T21:42:27Z

Will fix it in a bit.

rvagg · 2015-02-28T21:46:54Z

OK, my vote: release 1.4.2 now, get a 1.4.3 out ASAP, even if it's tomorrow (or even today?). 1.4.2 much less broken than 1.4.1 for Windows.

indutny · 2015-02-28T21:48:09Z

@rvagg I have a fix coming in a minute.

Only TCP and JSStream do support `.writev()` on all platforms at the moment. Ensure that it won't be enabled everywhere. Fix: nodejs#995

indutny · 2015-02-28T21:50:04Z

@rvagg done #1008

rvagg · 2015-02-28T21:52:55Z

I'm still voting for a 1.4.2 now, it's ready to go, 1.4.3 can be soon after as far as I can see this isn't quite as serious

indutny · 2015-02-28T22:00:02Z

@rvagg please put it into known problems then, and let's do a 1.4.3 right after it :) I'm quite sure that people might hit it in their code so releasing fix would be quite important.

piscisaureus · 2015-02-28T22:03:17Z

test-fs-access fails only if the working directory isn't clean. This is a bug in the test.
test-stdin-from-file failes because on windows there is no 'fd' property on a libuv handle object.

Neither failure is indicative of a serious issue.

So +1 on releasing after fixing test-child-process-stdio-big-write-end

rvagg · 2015-02-28T22:07:20Z

@piscisaureus to clarify: you're -1 on 1.4.2 going out and want test-child-process-stdio-big-write-end fixed before a release? we're in the same situation as 1.4.0 now that this has been tagged and built and ready to release so I can't bundle more in to a 1.4.2.

rvagg · 2015-02-28T22:18:39Z

going to release 1.4.2, it's tagged and I'm now -1 on deleting tags so may as well get this out and work on 1.4.3

rvagg · 2015-02-28T22:23:26Z

https://iojs.org/dist/latest/ it's out

ping @iojs/website and not we will have a 1.4.3 soon too

piscisaureus · 2015-02-28T22:24:07Z

Agreed, don't delete tags.

Only TCP and JSStream do support `.writev()` on all platforms at the moment. Ensure that it won't be enabled everywhere. Fix: #995 PR-URL: #1008 Reviewed-by: Bert Belder <[email protected]> Reviewed-By: Rod Vagg <[email protected]>

Fishrock123 · 2015-02-28T23:03:54Z

I don't have access to a computer right now. Cc @therebelrobot / @snostorm / @mikeal

snostorm · 2015-03-01T00:14:29Z

I'm online, I'll take a look at updating the site

snostorm · 2015-03-01T00:37:32Z

FYI slight delay as I'm doing this one "right" with a long overdue switch to handlebars for version/v8 version (since I am find/replacing those same fields anyway.) Almost to the finish line.

snostorm · 2015-03-01T00:50:56Z

Sitting at nodejs/iojs.org#251, I'll ping @iojs/website for a +1

snostorm · 2015-03-01T01:09:21Z

Heads up @rvagg I put up a second PR for 1.4.3 as well nodejs/iojs.org#252

rvagg mentioned this issue Feb 27, 2015

tls: fix typo handle._reading => handle.reading #994

Closed

brendanashworth mentioned this issue Feb 28, 2015

http: don't confuse automatic headers for others #828

Closed

popomore mentioned this issue Feb 28, 2015

1.4.2&1.4.3 changelog nodejs/nodejs-zh-CN#122

Closed

indutny added a commit to indutny/io.js that referenced this issue Feb 28, 2015

tls: proxy handle.reading back to parent handle

d83c9a3

Fix: nodejs#995

indutny mentioned this issue Feb 28, 2015

tls: proxy handle.reading back to parent handle #1003

Closed

indutny added a commit to indutny/io.js that referenced this issue Feb 28, 2015

tls: proxy handle.reading back to parent handle

1d59927

Fix: nodejs#995

indutny mentioned this issue Feb 28, 2015

tls: proxy handle.reading back to parent handle #1004

Closed

indutny added a commit to indutny/io.js that referenced this issue Feb 28, 2015

stream_base: .writev() has limited support

7bb1ca7

Only TCP and JSStream do support `.writev()` on all platforms at the moment. Ensure that it won't be enabled everywhere. Fix: nodejs#995

indutny mentioned this issue Feb 28, 2015

stream_base: .writev() has limited support #1008

Closed

rvagg closed this as completed Feb 28, 2015

snostorm mentioned this issue Mar 1, 2015

Release v1.4.3 nodejs/iojs.org#252

Closed

mscdex added the meta Issues and PRs related to the general management of the project. label Mar 25, 2015

This was referenced Jul 8, 2023

[Snyk] Security upgrade babel-loader from 8.3.0 to 9.1.3 aliscco/alisco-node#625

Open

[Snyk] Security upgrade babel-loader from 8.3.0 to 9.1.3 aliscco/alisco-node#626

Open

leonardoadame mentioned this issue Dec 3, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#477

Open

Release proposal: v1.4.2 #995

Release proposal: v1.4.2 #995

Comments

rvagg commented Feb 27, 2015

rvagg commented Feb 27, 2015

rvagg commented Feb 27, 2015

indutny commented Feb 28, 2015

rvagg commented Feb 28, 2015

2015-02-28, Version 1.4.2, @rvagg

Notable changes

Known issues

Commits

rvagg commented Feb 28, 2015

rvagg commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

rvagg commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

rvagg commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

rvagg commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

rvagg commented Feb 28, 2015

rvagg commented Feb 28, 2015

rvagg commented Feb 28, 2015

indutny commented Feb 28, 2015

indutny commented Feb 28, 2015

indutny commented Feb 28, 2015

indutny commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

rvagg commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

indutny commented Feb 28, 2015

indutny commented Feb 28, 2015

rvagg commented Feb 28, 2015

indutny commented Feb 28, 2015

rvagg commented Feb 28, 2015

indutny commented Feb 28, 2015

indutny commented Feb 28, 2015

rvagg commented Feb 28, 2015

indutny commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

rvagg commented Feb 28, 2015

rvagg commented Feb 28, 2015

rvagg commented Feb 28, 2015

piscisaureus commented Feb 28, 2015

Fishrock123 commented Feb 28, 2015

snostorm commented Mar 1, 2015

snostorm commented Mar 1, 2015

snostorm commented Mar 1, 2015

snostorm commented Mar 1, 2015