Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy JSON debug API removed as of V8 5.8 #9789

Closed
hashseed opened this issue Nov 24, 2016 · 7 comments
Closed

Legacy JSON debug API removed as of V8 5.8 #9789

hashseed opened this issue Nov 24, 2016 · 7 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol v8 engine Issues and PRs related to the V8 dependency.

Comments

@hashseed
Copy link
Member

This has been announced several times in the past two years [0][1]. Now that v8-inspector has taken over as a viable alternative, the old and unmaintained JSON debug API is now finally being removed from V8 [2]. I suggest migrating over to the inspector protocol if your tool talks to node/v8 via the legacy JSON debug API.

[0] https://docs.google.com/document/d/1M8DdgDldglYjQJ1mu0yBzwgR6lCX-ZKS_hxAJiCLT34/edit
[1] https://github.com/v8/v8/wiki/Debugging-Protocol
[2] https://chromium.googlesource.com/v8/v8/+/81a64aa5488602e4643f1ecc3beeddb8828a853c
@mscdex mscdex added debugger v8 engine Issues and PRs related to the V8 dependency. labels Nov 24, 2016
@ofrobots
Copy link
Contributor

/cc @nodejs/diagnostics @nodejs/v8.

@targos targos mentioned this issue Dec 5, 2016
Closed
@bnoordhuis bnoordhuis mentioned this issue Dec 7, 2016
Closed
@joshgav joshgav mentioned this issue Dec 8, 2016
Closed
@jkrems jkrems mentioned this issue Dec 13, 2016
Closed
9 tasks
@joshgav joshgav mentioned this issue Dec 15, 2016
Closed
4 tasks
@Fishrock123
Copy link
Contributor

Oh shoot was this the original issue, whoops I guess it was around the code-and-learn and no-one saw it. :(

@joshgav
Copy link
Contributor

joshgav commented Jan 9, 2017

FYI - Per @ofrobots here, removal of the old debug implementation has been deferred till V8 5.8.

Per #10117 It hasn't yet been decided (as of Jan 9) whether Node@8 will ship with V8 5.7 or 5.8.

@joshgav joshgav added the inspector Issues and PRs related to the V8 inspector protocol label Jan 9, 2017
@ofrobots ofrobots changed the title Legacy JSON debug API removed as of V8 5.7 Legacy JSON debug API removed as of V8 ~~5.7~~ 5.8 Jan 23, 2017
@ofrobots ofrobots changed the title Legacy JSON debug API removed as of V8 ~~5.7~~ 5.8 Legacy JSON debug API removed as of V8 5.8 Jan 23, 2017
@joshgav joshgav mentioned this issue Jan 23, 2017
Closed
3 tasks
@hashseed
Copy link
Member Author

The functionality of the legacy JSON debug API has been removed for V8 5.8: https://chromium.googlesource.com/v8/v8/+/876da98a5182a03f631f9ab4469bd6838225cb16

The API is still there so that Node.js still compiles. But these are only dummy functions.

@roblourens roblourens mentioned this issue Jan 31, 2017
Closed
joshgav added a commit to joshgav/node that referenced this issue Feb 10, 2017
@joshgav
lib: deprecate node --debug at runtime
e99228a 
Fixes: nodejs#9789
PR-URL: nodejs#10970
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@joshgav joshgav reopened this Feb 10, 2017
@joshgav
Copy link
Contributor

joshgav commented Feb 10, 2017

wow sorry for cluttering this issue up with all my interim test fixes :). also accidentally closed it with a "Fixes" comment, so reopened.

@jkrems jkrems mentioned this issue Feb 16, 2017
Closed
14 tasks
krydos pushed a commit to krydos/node that referenced this issue Feb 25, 2017
@joshgav @krydos
lib: deprecate node --debug at runtime
7dc1b50 
Fixes: nodejs#9789
PR-URL: nodejs#10970
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@refack
Copy link
Contributor

refack commented May 1, 2017

I wanted ask if a debug 2 inspect bridge was proposed (a proxy that translates the debug protocol into inspect) ?
Was it discussed how feasible that is?
Re: regression: 3rd party debuggers are incompatible with node8 nighlies

@kevinsawicki kevinsawicki mentioned this issue May 11, 2017
Merged
@Trott
Copy link
Member

Trott commented Aug 6, 2017

This seems close-able at this time. If I'm mistaken, by all means, re-open or comment.

@Trott Trott closed this as completed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mscdex @ofrobots @refack @Trott @Fishrock123 @hashseed @joshgav