-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky parallel/test-debug-port-cluster #6754
Comments
/cc @nodejs/testing |
I just saw this on FreeBSD too FWIW: https://ci.nodejs.org/job/node-test-commit-freebsd/2478/nodes=freebsd10-64/tapTestReport/test.tap-373/ |
And SmartOS: https://ci.nodejs.org/job/node-test-commit-smartos/2496/nodes=smartos14-64/console Something is definitely wrong with that test.... |
Er...uh...or perhaps equally likely, something is wrong with the code base but the test only catches it intermittently... |
The test is currently flaky and CI provides no real information because the test times out rather than failing on an assertion. Add logging to gather more information about the failure. Refs: nodejs#6754
This appears to fix the flakiness in this test: #6769 |
The test is currently flaky and CI provides no real information because the test times out rather than failing on an assertion. Add logging to gather more information about the failure. Refs: nodejs#6754
The test is currently flaky and CI provides no real information because the test times out rather than failing on an assertion. Add logging to gather more information about the failure. Refs: nodejs#6754 PR-URL: nodejs#6769 Reviewed-By: Colin Ihrig <[email protected]>
The test is currently flaky and CI provides no real information because the test times out rather than failing on an assertion. Add logging to gather more information about the failure. Refs: #6754 PR-URL: #6769 Reviewed-By: Colin Ihrig <[email protected]>
Remove port increment by `1337` which appears to sometimes result in a port that is already in use. There is no reason not to use `common.PORT`. PR-URL: #6769 Fixes: #6754 Reviewed-By: Colin Ihrig <[email protected]>
The test is currently flaky and CI provides no real information because the test times out rather than failing on an assertion. Add logging to gather more information about the failure. Refs: #6754 PR-URL: #6769 Reviewed-By: Colin Ihrig <[email protected]>
Remove port increment by `1337` which appears to sometimes result in a port that is already in use. There is no reason not to use `common.PORT`. PR-URL: #6769 Fixes: #6754 Reviewed-By: Colin Ihrig <[email protected]>
The test is currently flaky and CI provides no real information because the test times out rather than failing on an assertion. Add logging to gather more information about the failure. Refs: #6754 PR-URL: #6769 Reviewed-By: Colin Ihrig <[email protected]>
Remove port increment by `1337` which appears to sometimes result in a port that is already in use. There is no reason not to use `common.PORT`. PR-URL: #6769 Fixes: #6754 Reviewed-By: Colin Ihrig <[email protected]>
Example failure on CI: https://ci.nodejs.org/job/node-test-commit-plinux/2460/nodes=ppcbe-ubuntu1404/tapTestReport/test.tap-181/
/cc @bnoordhuis
The text was updated successfully, but these errors were encountered: