-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failed test: parallel/test-tls-0-dns-altname when using shared openssl #617
Comments
@jbergstroem This error is confirmed in my Ubuntu 14.04 with OpenSSL 1.0.1f installed by apt-get. Is this the same environment as yours? |
@jbergstroem Thanks. That means this error is independent of openssl version. I'll take a look at it. |
In the case of using openssl with shared library, reinterpret_cast<X509V3_EXT_I2V>(i2v_GENERAL_NAMES)) refers plt pointer so that SafeX509ExtPrint returns false. Fix it to check it with method of NID_subject_alt_name This patch originally was created by Fedor Indutny and Ben Noordhuis Fixes: nodejs#617
In the case of using openssl with shared library, reinterpret_cast<X509V3_EXT_I2V>(i2v_GENERAL_NAMES)) refers plt pointer so that SafeX509ExtPrint returns false. Fix it to check it with method of NID_subject_alt_name This patch originally was created by Fedor Indutny and Ben Noordhuis Fixes: #617 PR-URL: #800 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
Fixed in #800 . Close this. |
@shigeki confirmed fixed, thanks. |
@jbergstroem I reopen #618 . Could you give me more information? |
@shigeki Sorry, snuck a link in above comment. I'll post it to the other issue. |
The test checks for
process.versions.openssl
, which will always exist regardless of using a shared library or not. I'm not sure what we want to do here -- possibly just rewrite the check?The text was updated successfully, but these errors were encountered: