Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path.isAbsolute wrong output #6027

Closed
xenon-ua opened this issue Apr 3, 2016 · 1 comment
Closed

path.isAbsolute wrong output #6027

xenon-ua opened this issue Apr 3, 2016 · 1 comment
Labels
path Issues and PRs related to the path subsystem.

Comments

@xenon-ua
Copy link

xenon-ua commented Apr 3, 2016

node: v5.10.0
platform: Windows x64 v10.0.10586

In the documentation specified that path.isAbsolute('//server') should return true. But this command returns false on my platform:
image
@ChALkeR
Copy link
Member

ChALkeR commented Apr 3, 2016

Please provide an example with steps to reproduce (including your OS), the expected output and the actual output.

Update: the original post has been updated since this comment, it's fine now.

@ChALkeR ChALkeR added invalid Issues and PRs that are invalid. path Issues and PRs related to the path subsystem. labels Apr 3, 2016
@vkurchatkin vkurchatkin removed the invalid Issues and PRs that are invalid. label Apr 3, 2016
mscdex added a commit to mscdex/io.js that referenced this issue Apr 3, 2016
@mscdex
path: fix win32.isAbsolute()
d35449c 
Fixes: nodejs#6027
@mscdex mscdex mentioned this issue Apr 3, 2016
Closed
3 tasks
mscdex added a commit to mscdex/io.js that referenced this issue Apr 4, 2016
@mscdex
path: fix win32.isAbsolute() inconsistency
45a960e 
This commit fixes an inconsistency in absolute path checking compared
to the absolute path detection used by the other path.win32 functions.

Fixes: nodejs#6027
PR-URL: nodejs#6028
@jasnell jasnell closed this as completed in 3072546 Apr 4, 2016
MylesBorins pushed a commit that referenced this issue Apr 5, 2016
@mscdex
path: fix win32.isAbsolute() inconsistency
1c40079 
This commit fixes an inconsistency in absolute path checking compared
to the absolute path detection used by the other path.win32 functions.

Fixes: #6027
PR-URL: #6028
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

path: fix win32.isAbsolute() mscdex/io.js
3 participants
@ChALkeR @vkurchatkin @xenon-ua