Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-cluster-shared-leak (again) #5604

Closed
Trott opened this issue Mar 8, 2016 · 1 comment
Closed

Investigate flaky test-cluster-shared-leak (again) #5604

Trott opened this issue Mar 8, 2016 · 1 comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Mar 8, 2016

Example failure:

@Trott Trott added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Mar 8, 2016
@claudiorodriguez
Copy link
Contributor

I managed to reproduce this 50% of the time by destroying the connection like this:

      conn.on('error', function(e) {
        // ECONNRESET is OK
        if (e.code !== 'ECONNRESET')
          throw e;
      });
      setTimeout(function(){
        conn.destroy();
      }, 5);

I get the exact same error as in the log. I'm going to try some stuff to handle this case.

claudiorodriguez added a commit to claudiorodriguez/node that referenced this issue Mar 19, 2016
Test was flaky on centos7-64 due to an uncaught ECONNRESET
on the worker code. This catches the error so the process
will exit with code 0.

Fixes: nodejs#5604
Fishrock123 pushed a commit that referenced this issue Mar 22, 2016
Test was flaky on centos7-64 due to an uncaught ECONNRESET
on the worker code. This catches the error so the process
will exit with code 0.

Fixes: #5604
PR-URL: #5802
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 30, 2016
Test was flaky on centos7-64 due to an uncaught ECONNRESET
on the worker code. This catches the error so the process
will exit with code 0.

Fixes: #5604
PR-URL: #5802
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 30, 2016
Test was flaky on centos7-64 due to an uncaught ECONNRESET
on the worker code. This catches the error so the process
will exit with code 0.

Fixes: #5604
PR-URL: #5802
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants
@Trott @claudiorodriguez and others