TypeError: Method Map.prototype.set called on incompatible receiver #<AsyncContextFrame> #54503
Labels
async_hooks
Issues and PRs related to the async hooks subsystem.
Comments
RedYetiDev
added
the
async_hooks
bengl
added a commit
to bengl/node
that referenced
this issue
Aug 22, 2024
This gives a class prototype for AsyncContextFrame that contains the required methods, so that when we swap the prototype, ActiveAsyncContextFrame methods are used instead. Previously, the methods were defined in AsyncContextFrame, so swapping the prototype didn't swap those static methods. Also, make the ActiveAsyncContextFrame extend from Map. Fixes: nodejs#54503
|
I was excited about trying
|
$ node --experimental-async-context-frame -e "new async_hooks.AsyncLocalStorage().run({}, () => {})"
node:internal/async_context_frame:56
this.set(store, data);
^
TypeError: Method Map.prototype.set called on incompatible receiver #<AsyncContextFrame>
at AsyncContextFrame.set (<anonymous>)
at new AsyncContextFrame (node:internal/async_context_frame:56:10)
at AsyncLocalStorage.enterWith (node:internal/async_local_storage/async_context_frame:24:19)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_context_frame:30:10)
at [eval]:1:37
at runScriptInThisContext (node:internal/vm:209:10)
at node:internal/process/execution:118:14
at [eval]-wrapper:6:24
at runScript (node:internal/process/execution:101:62)
at evalScript (node:internal/process/execution:136:3)
Node.js v22.7.0 |
sendoru
pushed a commit
to sendoru/node
that referenced
this issue
Sep 1, 2024
This gives a class prototype for AsyncContextFrame that contains the required methods, so that when we swap the prototype, ActiveAsyncContextFrame methods are used instead. Previously, the methods were defined in AsyncContextFrame, so swapping the prototype didn't swap those static methods. Also, make the ActiveAsyncContextFrame extend from Map. Fixes: nodejs#54503 PR-URL: nodejs#54510 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95
pushed a commit
that referenced
this issue
Sep 12, 2024
This gives a class prototype for AsyncContextFrame that contains the required methods, so that when we swap the prototype, ActiveAsyncContextFrame methods are used instead. Previously, the methods were defined in AsyncContextFrame, so swapping the prototype didn't swap those static methods. Also, make the ActiveAsyncContextFrame extend from Map. Fixes: #54503 PR-URL: #54510 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
This gives a class prototype for AsyncContextFrame that contains the required methods, so that when we swap the prototype, ActiveAsyncContextFrame methods are used instead. Previously, the methods were defined in AsyncContextFrame, so swapping the prototype didn't swap those static methods. Also, make the ActiveAsyncContextFrame extend from Map. Fixes: nodejs#54503 PR-URL: nodejs#54510 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
This gives a class prototype for AsyncContextFrame that contains the required methods, so that when we swap the prototype, ActiveAsyncContextFrame methods are used instead. Previously, the methods were defined in AsyncContextFrame, so swapping the prototype didn't swap those static methods. Also, make the ActiveAsyncContextFrame extend from Map. Fixes: nodejs#54503 PR-URL: nodejs#54510 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v22.7.0
Platform
Subsystem
async_hooks
What steps will reproduce the bug?
node --experimental-async-context-frame -e "new async_hooks.AsyncLocalStorage().run({}, () => {})"How often does it reproduce? Is there a required condition?
100% always happens.
What is the expected behavior? Why is that the expected behavior?
The above command should just exit cleanly with no output.
What do you see instead?
Additional information
While the test suite includes the running of async-local-storage tests with the flag enabled, it doesn't actually check whether those files actually passed or failed. It just runs them. That's why this wasn't caught.
I think I have a fix ready. I'm just waiting on a compile to verify.
The text was updated successfully, but these errors were encountered: