Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io.js's performance counters conflict with node.js's on Windows 7 x64 #524

Closed
seishun opened this issue Jan 20, 2015 · 2 comments
Closed

io.js's performance counters conflict with node.js's on Windows 7 x64 #524

seishun opened this issue Jan 20, 2015 · 2 comments
Labels
confirmed-bug Issues with confirmed bugs. windows Issues and PRs related to the Windows platform.

Comments

@seishun
Copy link
Contributor

seishun commented Jan 20, 2015

Steps to reproduce:

  1. Install Node.js v0.10.35 with at least "Performance counters" checked
  2. Try to install io.js v1.0.3 with at least "Performance counters" checked

The installer fails and rolls back. It works just fine if you run the installer again.

This doesn't happen if "Performance counters" is unchecked in either of the installers. Other options don't seem to make any difference.

I'll try to reproduce this on a 32-bit Windows 7 when I get home.
@Fishrock123 Fishrock123 added the windows Issues and PRs related to the Windows platform. label Jan 22, 2015
@piscisaureus
Copy link
Contributor

This is a bug.
It can be fixed by changing one of the GUIDs in this file, but I don't know which one has to change.

@Fishrock123 Fishrock123 added the confirmed-bug Issues with confirmed bugs. label Feb 26, 2015
@SgtPooki SgtPooki mentioned this issue Feb 28, 2015
Closed
piscisaureus pushed a commit that referenced this issue Feb 28, 2015
@SgtPooki @piscisaureus
install: new performance counters provider guid
7887e11 
The io.js performance counters manifest conflicts with the one from
node, causing installer failures. Change the GUID in the io.js
performance counters manifest file to resolve the conflicts.

Fixes: #524
PR: #1001
Reviewed-by: Bert Belder <[email protected]>
@piscisaureus
Copy link
Contributor

Fixed, thanks to @SgtPooki, in 7887e11.

@samarthRT samarthRT mentioned this issue Jan 11, 2016
Closed
@snyk-bot snyk-bot mentioned this issue Feb 12, 2022
Open
@leonardoadame leonardoadame mentioned this issue Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piscisaureus @seishun @Fishrock123