-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util.inspect(new CompressionStream())
returns undefined
#52263
Comments
node/lib/internal/webstreams/compression.js Line 131 in 29de7f8
These lines are missing a |
Right, this is it! |
new CompressionStream()
returns undefined
util.inspect(new CompressionStream())
returns undefined
I opened a pr for this place thank you very much for the details |
Thanks @mertcanaltin! |
hey @ehmicky is this issue resolved? Or do you want someone to work on it? I would be more than happy to help and get started. |
This is being worked on at #52283 |
Understood, can you refer any good first issues for me, to get started with the project. I have a strong foundation of JavaScript and want to contribute to nodejs. Though all the good first issues are either resolved or someone else is working on it |
@mnik7044 That's great. However, you should probably open a new issue, since this question is unrelated. |
PR-URL: #52283 Fixes: #52263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #52283 Fixes: #52263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#52283 Fixes: nodejs#52263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#52283 Fixes: nodejs#52263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #52283 Fixes: #52263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Version
v21.7.1
Platform
Linux my-laptop 6.5.0-26-generic #26-Ubuntu SMP PREEMPT_DYNAMIC Tue Mar 5 21:19:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
stream/web
What steps will reproduce the bug?
This applies to
DecompressionStream()
as well.How often does it reproduce? Is there a required condition?
Earlier Node.js versions show the same behavior.
The behavior is the same regardless of whether it is accessed as a global variable or as an import from
stream/web
.The behavior happens on my machine, but it appears on other users that tried it too. I also tried it on an online REPL for Node.js.
What is the expected behavior? Why is that the expected behavior?
The return value should not be
undefined
.What do you see instead?
The return value is
undefined
.Additional information
I tried it in Firefox and Chrome, and it does not return
undefined
.When calling
CompressionStream.toString()
, it appears the correct source code is being used. That source code looks normal to me.What I find very strange is how
new ...
can returnundefined
. I through it was impossible. Even if theconstructor
returned a value (which it does not here), that value is ignored if it isundefined
.The text was updated successfully, but these errors were encountered: