Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-net-socket-timeout-unref #5128

Closed
Trott opened this issue Feb 7, 2016 · 10 comments
Closed

Investigate flaky test-net-socket-timeout-unref #5128

Trott opened this issue Feb 7, 2016 · 10 comments
Labels
arm Issues and PRs related to the ARM platform. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Feb 7, 2016

Example failure:
@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Feb 7, 2016
@santigimeno
Copy link
Member

@Trott Can you copy the output, please?

@Trott
Copy link
Member Author

Trott commented Feb 7, 2016

@santigimeno It's a timeout with no output from the test itself:

not ok 86 test-net-socket-timeout-unref.js
# TIMEOUT

@Trott
Copy link
Member Author

Trott commented Feb 28, 2016

Stress test: https://ci.nodejs.org/job/node-stress-single-test/549/nodes=pi2-raspbian-wheezy/console

@Trott
Copy link
Member Author

Trott commented Mar 28, 2016

Another instance from today. No new info, just documenting that it is still happening two-ish months later... :-/ https://ci.nodejs.org/job/node-test-binary-arm/1509/RUN_SUBSET=5,nodes=pi2-raspbian-wheezy/console

@Trott
Copy link
Member Author

Trott commented Mar 29, 2016

Created a branch and added a little logging in the hopes of finding out what's going on that's causing it to hang sometimes on pi2-raspbian-wheezy. Now running stress test for it: https://ci.nodejs.org/job/node-stress-single-test/575/nodes=pi2-raspbian-wheezy/console UPDATE: Of course adding the logging "fixes" the problem. Meh.

@Trott
Copy link
Member Author

Trott commented Apr 1, 2016

Another one from today: https://ci.nodejs.org/job/node-test-binary-arm/1553/RUN_SUBSET=0,nodes=pi2-raspbian-wheezy/console

@santigimeno
Copy link
Member

Of course adding the logging "fixes" the problem.

Highly unlikely, but maybe the refactoring to use newer syntax did something.
Maybe it's worth it launching the stress test again only with the logs.

@santigimeno
Copy link
Member

Nah it's only the const, disregard it

@Trott
Copy link
Member Author

Trott commented Apr 1, 2016

I think I have a fix for this... Stress test is 275 successful runs and counting: https://ci.nodejs.org/job/node-stress-single-test/583/nodes=pi2-raspbian-wheezy/console

Trott added a commit to Trott/io.js that referenced this issue Apr 1, 2016
@Trott
test: fix flaky test-net-socket-timeout-unref
b7c64fb 
Throw immediately on socket timeout rather than checking boolean in exit
handler.

Fixes: nodejs#5128
@Trott Trott mentioned this issue Apr 1, 2016
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Apr 1, 2016

Proposed fix: #6003

@Trott Trott closed this as completed in c60faf6 Apr 4, 2016
MylesBorins pushed a commit that referenced this issue Apr 5, 2016
@Trott
test: fix flaky test-net-socket-timeout-unref
2ab1237 
Throw immediately on socket timeout rather than checking boolean in exit
handler.

PR-URL: #6003
Fixes: #5128
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 11, 2016
@Trott
test: fix flaky test-net-socket-timeout-unref
e7877e6 
Throw immediately on socket timeout rather than checking boolean in exit
handler.

PR-URL: #6003
Fixes: #5128
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @santigimeno