Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad anchor in releases.md's table of contents #50368

Closed
targos opened this issue Oct 24, 2023 · 1 comment · Fixed by #50372
Closed

Bad anchor in releases.md's table of contents #50368

targos opened this issue Oct 24, 2023 · 1 comment · Fixed by #50372
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@targos
Copy link
Member

targos commented Oct 24, 2023

On https://github.com/nodejs/node/blob/main/doc/contributing/releases.md

The table content's anchor to "7.1 Updating the release (optional)" is #7-1-updating-the-release-optional

It should be #71-updating-the-release-optional
@targos targos added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Oct 24, 2023
@bryce-seefieldt
Copy link
Contributor

Would love to tackle this doc fix right away

bryce-seefieldt added a commit to bryce-seefieldt/node that referenced this issue Oct 24, 2023
@bryce-seefieldt
doc: Updated 7.1 anchor releases.md as per issue nodejs#50368
a3215ad
bryce-seefieldt added a commit to bryce-seefieldt/node that referenced this issue Oct 24, 2023
@bryce-seefieldt
Docs: nodejs#50368
7855add
bryce-seefieldt added a commit to bryce-seefieldt/node that referenced this issue Oct 24, 2023
@bryce-seefieldt
doc: fixed 7.1 anchor in releases.md's toc
1eaf84b 
Fixes: nodejs#50368
@bryce-seefieldt bryce-seefieldt mentioned this issue Oct 24, 2023
Merged
aduh95 pushed a commit to bryce-seefieldt/node that referenced this issue Oct 25, 2023
@bryce-seefieldt @aduh95
doc: fix TOC in releases.md
7b4295a 
Fixes: nodejs#50368
nodejs-github-bot pushed a commit that referenced this issue Oct 25, 2023
@bryce-seefieldt
doc: fix TOC in releases.md
6867c5a 
Fixes: #50368
PR-URL: #50372
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@bryce-seefieldt @alexfernandez
doc: fix TOC in releases.md
245cba2 
Fixes: nodejs#50368
PR-URL: nodejs#50372
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this issue Nov 11, 2023
@bryce-seefieldt @targos
doc: fix TOC in releases.md
d9f92bc 
Fixes: #50368
PR-URL: #50372
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
UlisesGascon pushed a commit that referenced this issue Dec 11, 2023
@bryce-seefieldt @UlisesGascon
doc: fix TOC in releases.md
0b31183 
Fixes: #50368
PR-URL: #50372
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fixed 7.1 anchor in releases.md's toc bryce-seefieldt/node
2 participants
@targos @bryce-seefieldt