Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating @Ethan-Arrowood as a Collaborator #50170

Closed
bnb opened this issue Oct 12, 2023 · 13 comments
Closed

Nominating @Ethan-Arrowood as a Collaborator #50170

bnb opened this issue Oct 12, 2023 · 13 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@bnb
Copy link
Contributor

bnb commented Oct 12, 2023

I noticed yesterday that @Ethan-Arrowood is not a collaborator on nodejs/node from a PR review he submitted. From what I've seen, he's made a number of exceptionally complex and valuable contributions - including doing a large amount of the initial work on Undici Fetch that (AFAIK) the version we now have is based off of, and implementing recursive readdir over more than a year, with 150 comments on the PR.

Additionally worth noting that @Ethan-Arrowood has contributed significantly to Undici, which is a dependency of Node.js and is within the Node.js organization:

cc @nodejs/collaborators
@Trott
Copy link
Member

Trott commented Oct 12, 2023

Ethan got their first contribution into Node.js at a code-and-learn in 2016.

Hooray for code-and-learn and all that, but also: 2016!!!!

I thought Ethan was already a collaborator for a long time. Yes, +1.

@Ethan-Arrowood
Copy link
Contributor

Thank you @bnb 💚

@Trott Yes, I still remember that event fondly. My first conference - I was a freshmen in university, learned so much, and met some life-long friends too!

@benjamingr
Copy link
Member

thought Ethan was already a collaborator for a long time. Yes, +1.

That, big +1

@Linkgoron
Copy link
Member

Big +1

@mhdawson
Copy link
Member

+1 from me

@Qard
Copy link
Member

Qard commented Oct 13, 2023

I thought Ethan was already a collaborator for a long time.

Same here. I assumed they were already a collaborator with all the contributions they've made. 😅

@Uzlopak
Copy link
Contributor

Uzlopak commented Oct 13, 2023

What? I thought he is are already a collaborator.

+1

@ruyadorno
Copy link
Member

+1 🎉

@VoltrexKeyva VoltrexKeyva added the meta Issues and PRs related to the general management of the project. label Oct 16, 2023
@joesepi
Copy link
Member

joesepi commented Oct 17, 2023

+1 🙌

@ErickWendel
Copy link
Member

OMG I also though he was already a collaborator hahaa +1 on the nomination!!

@debadree25
Copy link
Member

I think the nomination passes now! 🥳 cc @nodejs/tsc

@bnb
Copy link
Contributor Author

bnb commented Oct 23, 2023

yes, it's been >1 week with no -1s. @nodejs/tsc anyone willing to do onboarding?

@anonrig
Copy link
Member

anonrig commented Oct 23, 2023

Congrats Ethan! I'll reach out to @Ethan-Arrowood and start the onboarding process.

@Ethan-Arrowood Ethan-Arrowood mentioned this issue Oct 25, 2023
Closed
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@alexfernandez
doc: add Ethan-Arrowood as a collaborator
fe5f4c2 
PR-URL: nodejs#50393
Fixes: nodejs#50170
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this issue Nov 11, 2023
@targos
doc: add Ethan-Arrowood as a collaborator
f236657 
PR-URL: #50393
Fixes: #50170
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
UlisesGascon pushed a commit that referenced this issue Dec 11, 2023
@UlisesGascon
doc: add Ethan-Arrowood as a collaborator
d4be8fa 
PR-URL: #50393
Fixes: #50170
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add Ethan-Arrowood as a collaborator Ethan-Arrowood/node