Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps/zlib] Android arm64 build fails due to missing cpufeatures library #49766

Closed
MatteoBax opened this issue Sep 22, 2023 · 1 comment
Closed
Labels
android Issues and PRs related to the android platform.

Comments

@MatteoBax
Copy link
Contributor

When I compile the aarch64 Android project I get:

./deps/zlib/cpu_features.c:43:10: fatal error: 'cpu-features.h' file not found
#include <cpu-features.h>
         ^~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [deps/zlib/zlib.target.mk:127: /workspaces/codespaces-blank/node/out/Release/obj.target/zlib/deps/zlib/cpu_features.o] Error 1
make[1]: *** Waiting for unfinished jobs....
../deps/zlib/deflate.c:2003:31: warning: comparison of integers of different signs: 'IPos' (aka 'unsigned int') and 'int' [-Wsign-compare]
            if (s->prev_match == -1) {
                ~~~~~~~~~~~~~ ^  ~~
ar crsT /workspaces/codespaces-blank/node/out/Release/obj.target/deps/openssl/libopenssl.a @/workspaces/codespaces-blank/node/out/Release/obj.target/deps/openssl/libopenssl.a.ar-file-list
1 warning generated.
rm ba2e713c65e96ba2093f69b541eaf18cf990bba7.intermediate baa44214685e5f3e204d864ab741a526ee533e52.intermediate
make: *** [Makefile:134: node] Error 2

The commands I run to compile the project are:
./android-configure /home/codespace/Android/android-ndk-r26 31 aarch64
make -j4

@bnoordhuis
Copy link
Member

Google for "android cpu-features.h not found" - people hit this across various OSS projects and it's always some NDK setup issue.

I'm going to close this because a) it's not an issue with node itself, and b) android is not a supported platform, meaning: patches welcome but you're on your own if it doesn't work. Good luck.

@bnoordhuis bnoordhuis closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2023
@bnoordhuis bnoordhuis added the android Issues and PRs related to the android platform. label Sep 22, 2023
richardlau pushed a commit that referenced this issue Sep 29, 2023
Fixed cpu-features.h not found issue.

Co-Authored-By: Luigi Pinca <[email protected]>
Fixes: #49766
PR-URL: #49828
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
Fixed cpu-features.h not found issue.

Co-Authored-By: Luigi Pinca <[email protected]>
Fixes: nodejs#49766
PR-URL: nodejs#49828
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this issue Nov 11, 2023
Fixed cpu-features.h not found issue.

Co-Authored-By: Luigi Pinca <[email protected]>
Fixes: #49766
PR-URL: #49828
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
debadree25 pushed a commit to debadree25/node that referenced this issue Apr 15, 2024
Fixed cpu-features.h not found issue.

Co-Authored-By: Luigi Pinca <[email protected]>
Fixes: nodejs#49766
PR-URL: nodejs#49828
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Issues and PRs related to the android platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants