-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto
API documentation for x509.keyUsage
is wrong for all versions
#48727
Comments
nodejs-github-bot
pushed a commit
that referenced
this issue
Nov 20, 2023
PR-URL: #50603 Refs: #48727 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
targos
pushed a commit
that referenced
this issue
Nov 23, 2023
PR-URL: #50603 Refs: #48727 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
martenrichter
pushed a commit
to martenrichter/node
that referenced
this issue
Nov 26, 2023
PR-URL: nodejs#50603 Refs: nodejs#48727 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
lucshi
pushed a commit
to lucshi/node
that referenced
this issue
Nov 27, 2023
PR-URL: nodejs#50603 Refs: nodejs#48727 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
Nov 29, 2023
PR-URL: #50603 Refs: #48727 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
Nov 30, 2023
PR-URL: #50603 Refs: #48727 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon
pushed a commit
that referenced
this issue
Dec 11, 2023
PR-URL: #50603 Refs: #48727 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon
pushed a commit
that referenced
this issue
Dec 19, 2023
PR-URL: #50603 Refs: #48727 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected URL(s)
https://nodejs.org/api/crypto.html#x509keyusage
Description of the problem
The page for
x509.keyUsage
indicates that it returnsAn array detailing the key usages for this certificate.
while in fact it only returns the extended key usage for the certificate. For example:1.3.6.1.5.5.7.3.1
forTLS Web server
1.3.6.1.5.5.7.3.2
forTLS Web client
Key usages (not extend) are completely different are related to certificate extension under OID
2.5.29.15
to contain value in a bit array format.Key usage can have for definition: Digital signature, Non-repudiation, Key encipherment, Data encipherment, Key agreement, Certificate signing, CRL signing, Encipher only, Decipher only.
Therefore the API should be
x509.extKeyUsage
and the definitionAn array detailing the key extended usages for this certificate.
to match the reality of the function.The text was updated successfully, but these errors were encountered: