Button to choose module type is missing

[menzin]

API documentation used to have a button which allowed one to choose between CJS and EMS modules. It is gone.

[tniessen]

Which version of the docs are you referring to? Which code samples?

The only recent UI change that I can think of was #46928, but it has not been deployed yet AFAICT.

[menzin]

v19.8.1 --- and yesterday (on a different computer, but same versions) the buttons were present. I also tried v18.x [image: image.png]

…

On Mon, Mar 27, 2023 at 9:23 AM Tobias Nießen ***@***.***> wrote: Which version of the docs are you referring to? Which code samples? The only recent UI change that I can think of was #46928 <#46928>, but it has not been deployed yet AFAICT. — Reply to this email directly, view it on GitHub <#47268 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAFJ3DIXHFQWBKOVGD57HDW6GIF5ANCNFSM6AAAAAAWJDPWM4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tniessen]

Which browser are you using? I still see the switch button in the 19.8.1 documentation:

[menzin]

I am having the problem in both Chrome and Firefox. (It also happens in Brave, but that is essentially Chrome.) but it works in the Firefox Developer version. THX --- now I can at least direct my students there. Not sure why the buttons are missing in the other browsers. (p.s. I tried it with Chrome on both a PC and a Mac.)

…

On Mon, Mar 27, 2023 at 9:55 AM Tobias Nießen ***@***.***> wrote: Which browser are you using? I still see the switch button in the 19.8.1 documentation: [image: screenshot showing toggle button] <https://user-images.githubusercontent.com/3109072/227960246-158c78fe-6b54-4329-9f54-6b27c270cc7b.png> — Reply to this email directly, view it on GitHub <#47268 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAFJ3B77Y3N5FRXY6K3WZTW6GL6NANCNFSM6AAAAAAWJDPWM4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tniessen]

cc @nodejs/website @nodejs/documentation

[ovflowd]

I am not able to reproduce this issue. Could more testing parameters be added here?

Does this happen on a specific set of API docs pages? We haven't had any code change recently or in ages that would affect this...

[menzin]

I have had the following problem with th *http module, but not with the events module* I have a missing button on Chrome (both Windows 10 and Mac) and on Firefox (both Windows 10 and Mac) and Safari (Mac) but NOT on Firefox Developer Version (Windows 10).

…

On Mon, Mar 27, 2023 at 1:04 PM Claudio Wunder ***@***.***> wrote: I am not able to reproduce this issue. Could more testing parameters be added here? Does this happen on a specific set of API docs pages? We haven't had any code change recently or in ages that would affect this... — Reply to this email directly, view it on GitHub <#47268 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAFJ3F4XE6KP35ZR23OLJDW6HCBNANCNFSM6AAAAAAWJDPWM4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mscdex]

I believe it's because the http module docs are missing ESM versions of various code blocks.

[tniessen]

That would be my guess, too, but @menzin has said more than once that it works in some browsers but not in others.