-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl: preview removed when press ESC key #46876
Labels
repl
Issues and PRs related to the REPL subsystem.
Comments
meixg
added a commit
to meixg/node
that referenced
this issue
Feb 28, 2023
meixg
added a commit
to meixg/node
that referenced
this issue
Feb 28, 2023
meixg
added a commit
to meixg/node
that referenced
this issue
Feb 28, 2023
meixg
added a commit
to meixg/node
that referenced
this issue
Mar 3, 2023
nodejs-github-bot
pushed a commit
that referenced
this issue
Mar 16, 2023
Fix: #46876 PR-URL: #46878 Fixes: #46876 Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this issue
Mar 18, 2023
Fix: #46876 PR-URL: #46878 Fixes: #46876 Reviewed-By: Ruben Bridgewater <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Jul 6, 2023
Fix: #46876 PR-URL: #46878 Fixes: #46876 Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
18.12.1
Platform
Darwin 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_X86_64 x86_64
Subsystem
repl
What steps will reproduce the bug?
In repl
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior?
Keep preview, only remove autocomplete
ChromeDevTools also keep the preview after pressing the ESC key
What do you see instead?
The preview is removed
Additional information
The preview is removed by this PR: #42053
The text was updated successfully, but these errors were encountered: