-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a TransformStream accesses Object.prototype.type #46355
Comments
There's a WPT for this at https://raw.githubusercontent.com/web-platform-tests/wpt/master/fetch/api/basic/stream-safe-creation.any.js although it relies on fetch things. There might be one for webstreams only but I haven't looked. |
debadree25
added a commit
to debadree25/node
that referenced
this issue
Jan 28, 2023
nodejs-github-bot
pushed a commit
that referenced
this issue
Feb 2, 2023
Fixes: #46355 PR-URL: #46389 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Feb 18, 2023
Fixes: #46355 PR-URL: #46389 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Apr 11, 2023
Fixes: #46355 PR-URL: #46389 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v19.5.0
Platform
No response
Subsystem
webstreams
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior?
It shouldn't access Object.prototype.type.
What do you see instead?
Additional information
This can be fixed by adding
type: undefined
to the WritableStream and ReadableStream options that TransformStream creates. Or making it a null prototype (via__proto__: null
) should also probably work.The text was updated successfully, but these errors were encountered: