-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-dgram-pingpong flaky on parallel runs #4526
Comments
I doubt this is the problem, but just in case: Is there any special firewalling or throttling on those machines? It looks like this test fires 1500 UDP packets in (let's say) half a second or so. |
@Trott: iptables looks squeaky clean and the vm admin dashboard doesn't point to any firewalling. |
At least one other "flaky on PPC when run in parallel" test is a test that is also network intensive. In #4527, you report that Maybe there's something the provider is doing that we can't see from the host itself? (I think all this stuff happens on localhost, so it wouldn't be on the subnet or anything like that, I imagine...) |
Regarding provider: that's why i checked the dashboard (there's usually ways to access firewalling from there). I'll create a support ticket and ask. |
Maybe this test should just be moved to sequential. Maybe it's just too network (or other resrouce) intensive for some platforms. |
Probable fix: #4615 |
I think #4615 fixed this. Please re-open if I'm mistaken. |
:/ |
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ Ref: nodejs#4830 Ref: nodejs#3635 Ref: nodejs#4526
The sudden-seeming spike in this failing on Raspberry Pi suggests either a regression in the code or else a change in CI devices or other CI infrastructure. |
All of them failing. :-( |
I added some logging for each So my inclination would be to alter the test to tolerate an occasional missed message. Thoughts? /cc @rvagg (who, as best as I can tell, is The Raspberry Pi Person around here to the extent that we have one) Here's the stress test using the additional logging: https://ci.nodejs.org/job/node-stress-single-test/409/nodes=pi2-raspbian-wheezy/console |
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. Fixes: nodejs#4526
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by sending 5 messages per server rather than 500. Fixes: nodejs#4526
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: nodejs#4526
sorry for the delay, I have nothing useful to add here sorry, let me know if I'm needed to dive deeper here cause I'm only passing a cursory glance over the issue right now |
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: nodejs#5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: nodejs#4830 Ref: nodejs#3635 Ref: nodejs#4526
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: nodejs#4526 PR-URL: nodejs#5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
It's been very frequent on the ppc machines during
-J
runs as of late: https://ci.nodejs.org/job/node-test-commit-plinux/nodes=ppcbe-fedora20/ws/test.tap/*view*/The text was updated successfully, but these errors were encountered: