Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test - node-api/test_buffer/test_finalizer #43389

Closed
daeyeon opened this issue Jun 12, 2022 · 7 comments
Closed

Investigate flaky test - node-api/test_buffer/test_finalizer #43389

daeyeon opened this issue Jun 12, 2022 · 7 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. node-api Issues and PRs related to the Node-API.

Comments

@daeyeon
Copy link
Member

daeyeon commented Jun 12, 2022

Test

node-api/test_buffer/test_finalizer

Platform

node-test-commit-aix

Console output

Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
    at Proxy.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/common/index.js:396:10)
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/node-api/test_buffer/test_finalizer.js:9:40)
    at Module._compile (node:internal/modules/cjs/loader:1106:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1160:10)
    at Module.load (node:internal/modules/cjs/loader:984:32)
    at Module._load (node:internal/modules/cjs/loader:830:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
    at Proxy.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/common/index.js:396:10)
    at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/node-api/test_buffer/test_finalizer.js:15:42
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/node-api/test_buffer/test_finalizer.js:21:3)
    at Module._compile (node:internal/modules/cjs/loader:1106:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1160:10)
    at Module.load (node:internal/modules/cjs/loader:984:32)
    at Module._load (node:internal/modules/cjs/loader:830:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

Build links

Additional information

No response
@daeyeon daeyeon added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jun 12, 2022
@F3n67u F3n67u added the node-api Issues and PRs related to the Node-API. label Jun 12, 2022
@mhdawson
Copy link
Member

This seems to be occuring across machines by looking in - nodejs/reliability#299 but more often on AIX machines

@mhdawson
Copy link
Member

Earliest I can find in the reliability reports is 28 May - nodejs/reliability#291

@mhdawson
Copy link
Member

This landed around that time - #36510

@mhdawson
Copy link
Member

#36510 added the test that is now failing.

image

@mhdawson
Copy link
Member

mhdawson commented Jun 13, 2022 •
edited
Loading

I'm going to mark the test as flaky and then put on my list to take a look at. I think this makes sense since it is the top most failed test in the reliability report and best to get that out of the way as it may take me a bit of time to get to looking at it.

mhdawson added a commit to mhdawson/io.js that referenced this issue Jun 13, 2022
@mhdawson
test: mark test_buffer/test_finalizer flaky
be1b10e 
Refs: nodejs#43389

Mark new test as flaky as it seems to have
had intermittent failures since it was added.

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson mhdawson mentioned this issue Jun 13, 2022
Closed
@mhdawson
Copy link
Member

PR to mark flaky for now - #43414

mhdawson added a commit that referenced this issue Jun 14, 2022
@mhdawson
test: mark test_buffer/test_finalizer flaky
73d8db8 
Refs: #43389

Mark new test as flaky as it seems to have
had intermittent failures since it was added.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #43414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this issue Jun 16, 2022
@mhdawson @danielleadams
test: mark test_buffer/test_finalizer flaky
42c2115 
Refs: #43389

Mark new test as flaky as it seems to have
had intermittent failures since it was added.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #43414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@mhdawson
Copy link
Member

Fixed by - #43418

targos pushed a commit that referenced this issue Jul 12, 2022
@mhdawson @targos
test: mark test_buffer/test_finalizer flaky
b295283 
Refs: #43389

Mark new test as flaky as it seems to have
had intermittent failures since it was added.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #43414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit that referenced this issue Jul 31, 2022
@mhdawson @targos
test: mark test_buffer/test_finalizer flaky
f49d66b 
Refs: #43389

Mark new test as flaky as it seems to have
had intermittent failures since it was added.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #43414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@mhdawson @guangwong
test: mark test_buffer/test_finalizer flaky
c65d172 
Refs: nodejs/node#43389

Mark new test as flaky as it seems to have
had intermittent failures since it was added.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs/node#43414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daeyeon @mhdawson @F3n67u