-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: performance warning about timeout.unref()
is not clear.
#42239
Comments
@nodejs/timers |
It had been added for a long time: bdd1a74 |
I checked the code in v0.9.1, there is indeed a Lines 254 to 267 in e6ce259
But this is not the case now. |
VoltrexKeyva
added
the
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
label
Mar 8, 2022
danielleadams
pushed a commit
to danielleadams/node
that referenced
this issue
Apr 21, 2022
resolve: nodejs#42239 PR-URL: nodejs#42241 Fixes: nodejs#42239 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this issue
Apr 25, 2022
resolve: nodejs#42239 PR-URL: nodejs#42241 Fixes: nodejs#42239 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected URL(s)
https://nodejs.org/api/timers.html#timeoutunref
Description of the problem
The documentation for
timeout.unref()
ends with this warning:I don't understand what this means.
"creates an internal timer that will wake the Node.js event loop" sounds roughly like what
setTimeout
does. Is it different?Tangent: I also noticed that the docs for the new
timersPromises.setInterval
(link) supports theref
parameter but there's no similar warning there.The text was updated successfully, but these errors were encountered: