Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-http-exit-delay #4045

Closed
Trott opened this issue Nov 27, 2015 · 1 comment
Closed

Investigate flaky test-http-exit-delay #4045

Trott opened this issue Nov 27, 2015 · 1 comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Nov 27, 2015

Example failure:
@Trott Trott added the test Issues and PRs related to the tests. label Nov 27, 2015
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 27, 2015
Trott added a commit that referenced this issue Nov 28, 2015
@Trott
test: refactor test-http-exit-delay
97626c9 
test-http-exit-delay was introduced to confirm the removal of a 1 second
delay that can occur when exiting node after an http request.

This change refactors the test for simplicity and also in the hopes of
either eliminating flakiness on CI or, if not that, at least making
the source of the flakiness easier to track down.

Ref: 16b59cbc
Fixes: #4045
@Trott Trott mentioned this issue Nov 28, 2015
Closed
@Trott
Copy link
Member Author

Trott commented Nov 30, 2015

PR to fix: #4055

@Trott Trott closed this as completed in 8a2acd4 Dec 4, 2015
Trott added a commit that referenced this issue Dec 5, 2015
@Trott @rvagg
test: refactor test-http-exit-delay
be41eb7 
test-http-exit-delay was introduced to confirm the removal of a 1 second
delay that can occur when exiting node after an http request.

This change refactors the test for simplicity and also in the hopes of
either eliminating flakiness on CI or, if not that, at least making
the source of the flakiness easier to track down.

Ref: 16b59cbc
Fixes: #4045
PR-URL: #4055
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this issue Dec 15, 2015
@Trott
test: refactor test-http-exit-delay
79720aa 
test-http-exit-delay was introduced to confirm the removal of a 1 second
delay that can occur when exiting node after an http request.

This change refactors the test for simplicity and also in the hopes of
either eliminating flakiness on CI or, if not that, at least making
the source of the flakiness easier to track down.

Ref: 16b59cbc
Fixes: #4045
PR-URL: #4055
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this issue Dec 17, 2015
@Trott @jasnell
test: refactor test-http-exit-delay
43e3b69 
test-http-exit-delay was introduced to confirm the removal of a 1 second
delay that can occur when exiting node after an http request.

This change refactors the test for simplicity and also in the hopes of
either eliminating flakiness on CI or, if not that, at least making
the source of the flakiness easier to track down.

Ref: 16b59cbc
Fixes: #4045
PR-URL: #4055
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this issue Dec 23, 2015
@Trott @jasnell
test: refactor test-http-exit-delay
eb649fb 
test-http-exit-delay was introduced to confirm the removal of a 1 second
delay that can occur when exiting node after an http request.

This change refactors the test for simplicity and also in the hopes of
either eliminating flakiness on CI or, if not that, at least making
the source of the flakiness easier to track down.

Ref: 16b59cbc
Fixes: #4045
PR-URL: #4055
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@Trott
test: refactor test-http-exit-delay
17b72c9 
test-http-exit-delay was introduced to confirm the removal of a 1 second
delay that can occur when exiting node after an http request.

This change refactors the test for simplicity and also in the hopes of
either eliminating flakiness on CI or, if not that, at least making
the source of the flakiness easier to track down.

Ref: nodejs@16b59cbc
Fixes: nodejs#4045
PR-URL: nodejs#4055
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @Trott