Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-tls-no-sslv3 and shared openssl with disabled SSLv3 #3927

Closed
kapouer opened this issue Nov 19, 2015 · 1 comment
Closed

test-tls-no-sslv3 and shared openssl with disabled SSLv3 #3927

kapouer opened this issue Nov 19, 2015 · 1 comment
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Comments

@kapouer
Copy link
Contributor

kapouer commented Nov 19, 2015

Hi,

debian/sid is transitioning
to an openssl version built with disabled SSLv3 support.
It is disabled to the point that
openssl s_client -connect example.com:443 -ssl3
fails immediately with unknown option -ssl3 error message.

The test actually fails when checking that the server emits a clientError:
because the client fails immediately, no failure happens on the server.

I can easily fix the test on debian but am not sure if it should be fixed here
as well. What do you think ?
@ChALkeR ChALkeR added test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. labels Nov 19, 2015
@bnoordhuis bnoordhuis mentioned this issue Dec 8, 2015
Merged
@bnoordhuis
Copy link
Member

#4204

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Dec 9, 2015
@bnoordhuis
test: don't assume openssl s_client supports -ssl3
1e89830 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: nodejs#3927
PR-URL: nodejs#4204
Reviewed-By: Rich Trott <[email protected]>
bnoordhuis added a commit that referenced this issue Dec 15, 2015
@bnoordhuis @cjihrig
test: don't assume openssl s_client supports -ssl3
42b7f1a 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: #3927
PR-URL: #4204
Reviewed-By: Rich Trott <[email protected]>
bnoordhuis added a commit that referenced this issue Dec 30, 2015
@bnoordhuis
test: don't assume openssl s_client supports -ssl3
6a0ec14 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: #3927
PR-URL: #4204
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
@bnoordhuis
test: don't assume openssl s_client supports -ssl3
6bc1b1c 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: #3927
PR-URL: #4204
Reviewed-By: Rich Trott <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@bnoordhuis
test: don't assume openssl s_client supports -ssl3
146e10b 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: nodejs#3927
PR-URL: nodejs#4204
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kapouer @bnoordhuis @ChALkeR