Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL: pathname setter change #39059

Closed
annevk opened this issue Jun 17, 2021 · 1 comment
Closed

URL: pathname setter change #39059

annevk opened this issue Jun 17, 2021 · 1 comment
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@annevk
Copy link

annevk commented Jun 17, 2021

See whatwg/url#582 and web-platform-tests/wpt#27720.

cc @jasnell
@annevk annevk mentioned this issue Jun 17, 2021
Merged
3 tasks
RaisinTen added a commit to RaisinTen/node that referenced this issue Jun 17, 2021
@RaisinTen
url: pathname setter change
da05e9e 
Fixes: nodejs#39059
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen mentioned this issue Jun 17, 2021
Closed
@RaisinTen
Copy link
Contributor

PR: #39060

@Ayase-252 Ayase-252 added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jun 17, 2021
RaisinTen added a commit to RaisinTen/node that referenced this issue Jun 18, 2021
@RaisinTen
url: prevent pathname setter from erasing path of path-only URLs
514e3fd 
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.

The changes done in all files except src/node_url.cc has been done by
running:

```console
git node wpt url
```

Fixes: nodejs#39059
Signed-off-by: Darshan Sen <[email protected]>
RaisinTen added a commit to RaisinTen/node that referenced this issue Jun 18, 2021
@RaisinTen
url: prevent pathname setter from erasing path of path-only URLs
841563e 
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.

The changes in all files except `src/node_url.cc` have been done by
running:

```console
git node wpt url
```

Fixes: nodejs#39059
Signed-off-by: Darshan Sen <[email protected]>
RaisinTen added a commit to RaisinTen/node that referenced this issue Jun 26, 2021
@RaisinTen
url: prevent pathname setter from erasing path of path-only URLs
143d369 
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.

The changes in all files except `src/node_url.cc` have been done by
running:

```console
git node wpt url
```

Fixes: nodejs#39059
Signed-off-by: Darshan Sen <[email protected]>
RaisinTen added a commit to RaisinTen/node that referenced this issue Jul 10, 2021
@RaisinTen
url: prevent pathname setter from erasing path of path-only URLs
0a7e75d 
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.

The changes in all files except `src/node_url.cc` have been done by
running:

```console
git node wpt url
```

Fixes: nodejs#39059
Signed-off-by: Darshan Sen <[email protected]>
targos pushed a commit that referenced this issue Jul 20, 2021
@RaisinTen @targos
url: prevent pathname setter from erasing path of path-only URLs
4b52a34 
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.

The changes in all files except `src/node_url.cc` have been done by
running:

```console
git node wpt url
```

Fixes: #39059
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #39060
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
BethGriggs pushed a commit that referenced this issue Jul 29, 2021
@RaisinTen @BethGriggs
url: prevent pathname setter from erasing path of path-only URLs
68fd6d5 
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.

The changes in all files except `src/node_url.cc` have been done by
running:

```console
git node wpt url
```

Fixes: #39059
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #39060
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

url: prevent pathname setter from erasing path of path-only URLs RaisinTen/node
3 participants
@annevk @Ayase-252 @RaisinTen