Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

>=node-16.0.0: failed test # 12 in parallel/test-repl-history-navigation #38558

Closed
mkszuba opened this issue May 5, 2021 · 2 comments · Fixed by #38564
Closed

>=node-16.0.0: failed test # 12 in parallel/test-repl-history-navigation #38558

mkszuba opened this issue May 5, 2021 · 2 comments · Fixed by #38564
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.

Comments

@mkszuba
Copy link

mkszuba commented May 5, 2021

  • Version: 16.0.0, 16.1.0
  • Platform: Linux

What steps will reproduce the bug?

For me, it occurs when I running the Node.js Python test suite:

python3.8 tools/test.py --mode=Release --flaky-tests=dontcare -J message parallel sequential

How often does it reproduce? Is there a required condition?

Always.

What is the expected behavior?

All tests pass.

What do you see instead?

One of the tests fail, see the attachment for its output.

== release test-repl-history-navigation ===
Path: parallel/test-repl-history-navigation
Failed test # 12
Last outputs: [
  '> ',
  'c',
  'o',
  'n',
  's',
  't',
  ' ',
  'u',
  't',
  'i',
  'l',
  ' ',
  '=',
  ' ',
  '{',
  '}',
  'undefined\n',
  '> ',
  'u',
  't',
  ' // il',
  'il'
]
/tmp/node-v16.1.0/test/parallel/test-repl-history-navigation.js:645
            throw e;
            ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'il'
- '\n// {}'
    at Writable.write [as _write] (/tmp/node-v16.1.0/test/parallel/test-repl-history-navigation.js:639:20)
    at writeOrBuffer (node:internal/streams/writable:389:12)
    at _write (node:internal/streams/writable:330:10)
    at Writable.write (node:internal/streams/writable:334:10)
    at REPLServer._writeToOutput (node:readline:451:17)
    at REPLServer.Interface._insertString (node:readline:618:12)
    at node:internal/repl/utils:272:14
    at completionGroupsLoaded (node:repl:1501:5)
    at REPLServer.complete (node:repl:1403:7)
    at REPLServer.completer (node:repl:709:5) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'il',
  expected: '\n// {}',
  operator: 'strictEqual'
}
Command: out/Release/node --expose-internals /tmp/node-v16.1.0/test/parallel/test-repl-history-navigation.js
@aduh95
Copy link
Contributor

aduh95 commented May 5, 2021

That's something we stumble upon on #38141 (review), I'm unsure what's causing this behaviour and why it doesn't reproduce in a consistent way. Have you built node on your local machine or are you getting it from somewhere else? Any chance you could share what configure options have been used on compilation?

@aduh95 aduh95 added repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. labels May 5, 2021
@mkszuba
Copy link
Author

mkszuba commented May 5, 2021

I build it locally, with the configuration stage invoked by:

python3.8 configure.py --prefix=/usr --dest-cpu=x64 --shared-brotli --shared-cares --shared-libuv --shared-nghttp2 --shared-zlib --shared-openssl --openssl-use-def-ca-store --without-dtrace --without-inspector --with-intl=full-icu

aduh95 added a commit to aduh95/node that referenced this issue May 6, 2021
@aduh95 aduh95 closed this as completed in 7c8a608 May 9, 2021
targos pushed a commit that referenced this issue May 17, 2021
Fixes: #38558

PR-URL: #38564
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants