Ensure '(node)' prefix for stdout logging

[silverwind]

To discern messages logged by node vs. messages logged by the application, we agreed to prefix messages printed to stdout with (node) like here or here.

There are however cases in the code base where this prefix is missing like here which gets logged here. I'm sure there are more cases in src, possibly even some in lib. One could search for console or the printf variants to identify these cases.

[bnoordhuis]

PID would be useful too. Think clustered applications.

[JungMinu]

@silverwind @bnoordhuis I will handle this 😄

[silverwind]

@JungMinu thanks!

I don't see PID as a requirement, but we could do (node 12345) message. Maybe through a shared function in lib/internal/util.js, if all our prints come from JS.

[JungMinu]

@silverwind Thanks 😃

[silverwind]

Let's wait for others to chime in on the PID topic, I feel it's kind of unnecessary. Maybe only include it when in a cluster child?

[JungMinu]

@silverwind Yes, 👍

[JungMinu]

Let's wait for others to chime in on the PID topic, I feel it's kind of unnecessary. Maybe only include it when in a cluster child?

@Fishrock123 Whaddya reckon?

[cjihrig]

Might want to always include it for consistency with debug(). Also, not all child processes are cluster workers.

[silverwind]

Maybe (node) [pid] message would be a better format? I'm still not conviced we need to include the PID, and would love some more feedback about that from collaborators.

[bnoordhuis]

Think of it like this: is there ever a time when the PID is distracting or harmful? If not, then include it - because there will be times when it's invaluable.

[jwueller]

Absolutely, the PID can be vital. In terms of format, (node) [pid] is
easier to grep for than (node pid).

Ben Noordhuis [email protected] schrieb am Fr., 13. Nov. 2015,
09:22:

Think of it like this: is there ever a time when the PID is distracting or
harmful? If not, then include it - because there will be times when it's
invaluable.

—
Reply to this email directly or view it on GitHub
#3789 (comment).

[JungMinu]

I will submit a PR for this issue ASAP, Thanks 😄

[JungMinu]

a PR for this issue:#3833

[silverwind]

Resolved in 94b9948