We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup a node instance,
» node
and run the following javascript code.
tty = require('tty');tty.isatty(1000000000000000000);
Then an abort occurs.
This abort can always be triggered following the steps above.
If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.
» node 134 ↵ zys@zys-X299-UD4-Pro Welcome to Node.js v14.15.1. Type ".help" for more information. > tty = require('tty');tty.isatty(1000000000000000000); node[57893]: ../src/tty_wrap.cc:73:static void node::TTYWrap::IsTTY(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `(fd) >= (0)' failed. 1: 0xa03530 node::Abort() [node] 2: 0xa035ae [node] 3: 0xaea222 [node] 4: 0xbe369b [node] 5: 0xbe4c46 [node] 6: 0xbe52c6 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node] 7: 0x13ff259 [node] [1] 57893 abort (core dumped) node
The text was updated successfully, but these errors were encountered:
tty: validate file descriptor to avoid nt32 overflow
a8d67cd
Fixes: nodejs#37805
tty: validate file descriptor to avoid int32 overflow
a37d2cf
134fb5a
3452618
Fixes: #37805 PR-URL: #37809 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
d89d55a
Successfully merging a pull request may close this issue.
What steps will reproduce the bug?
Setup a node instance,
and run the following javascript code.
Then an abort occurs.
How often does it reproduce? Is there a required condition?
This abort can always be triggered following the steps above.
What is the expected behavior?
If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.
What do you see instead?
Additional information
The text was updated successfully, but these errors were encountered: