-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debugger: --debug-brk should pause until debug client connects #3589
Comments
/cc @indutny |
It appears that, as it is currently written, 'use strict';
const common = require('../common');
const assert = require('assert');
const spawnSync = require('child_process').spawnSync;
const args = [`--debug-brk=${common.PORT}`, '-e', '0'];
const proc = spawnSync(process.execPath, args, {encoding: 'utf8'});
assert(/Debugger listening on/.test(proc.stderr)); |
I added |
4 tasks
3 tasks
Possible fix: #7089 |
Trott
added a commit
to Trott/io.js
that referenced
this issue
Jun 4, 2016
The command line flag `--debug-brk` was ignored when the `-e` flag was also present. This change allows the flags to both be honored when they are used in a single command line. Fixes: nodejs#3589
evanlucas
pushed a commit
that referenced
this issue
Jun 15, 2016
The command line flag `--debug-brk` was ignored when the `-e` flag was also present. This change allows the flags to both be honored when they are used in a single command line. PR-URL: #7089 Fixes: #3589 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #3585 (comment). Right now it quits:
I think the intended behavior is for it to wait until a debug client connects, unlike e.g.
--debug
.The text was updated successfully, but these errors were encountered: