Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: clean up tools/v8_gypfiles/toolchain.gypi #34256

Closed
bnoordhuis opened this issue Jul 8, 2020 · 2 comments
Closed

build: clean up tools/v8_gypfiles/toolchain.gypi #34256

bnoordhuis opened this issue Jul 8, 2020 · 2 comments
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors.

Comments

@bnoordhuis
Copy link
Member

The linux_use_gold_flag, linux_use_bundled_gold and linux_use_bundled_binutils flags are unused and can be removed, our build always disables them.

tools/gyp_node.py sets the flags, they can be removed too.
@bnoordhuis bnoordhuis added build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. labels Jul 8, 2020
@Nishikoh
Copy link

Nishikoh commented Jul 8, 2020

Hi, I'd like to tackle that :D

@ghost ghost mentioned this issue Jul 9, 2020
Closed
1 task
@ghost
Copy link

ghost commented Jul 9, 2020

See #34268

@Nishikoh Nishikoh mentioned this issue Jul 9, 2020
Closed
1 task
gengjiawen pushed a commit that referenced this issue Jul 29, 2020
@gengjiawen
build: toolchain.gypi and node_gyp.py cleanup
f93e3a3 
Removed `linux_use_gold_flag`, `linux_use_bundled_gold` and `linux_use_bundled_binutils` flags from
`tools/v8_gypfiles/toolchain.gypi` and `/tools/gyp_node.py`.

Fixes: #34256

PR-URL: #34268
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this issue Aug 5, 2020
@codebytere
build: toolchain.gypi and node_gyp.py cleanup
70e9ece 
Removed `linux_use_gold_flag`, `linux_use_bundled_gold` and `linux_use_bundled_binutils` flags from
`tools/v8_gypfiles/toolchain.gypi` and `/tools/gyp_node.py`.

Fixes: #34256

PR-URL: #34268
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@addaleax
build: toolchain.gypi and node_gyp.py cleanup
ebd9461 
Removed `linux_use_gold_flag`, `linux_use_bundled_gold` and `linux_use_bundled_binutils` flags from
`tools/v8_gypfiles/toolchain.gypi` and `/tools/gyp_node.py`.

Fixes: #34256

PR-URL: #34268
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@addaleax
build: toolchain.gypi and node_gyp.py cleanup
343894f 
Removed `linux_use_gold_flag`, `linux_use_bundled_gold` and `linux_use_bundled_binutils` flags from
`tools/v8_gypfiles/toolchain.gypi` and `/tools/gyp_node.py`.

Fixes: #34256

PR-URL: #34268
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
3 participants
@bnoordhuis @gengjiawen @Nishikoh