Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macOS Big Sur (10.16 / 11.0) #34043

Closed
mattpilott opened this issue Jun 24, 2020 · 21 comments
Closed

Support macOS Big Sur (10.16 / 11.0) #34043

mattpilott opened this issue Jun 24, 2020 · 21 comments
Labels
macos Issues and PRs related to the macOS platform / OSX.

Comments

@mattpilott
Copy link

mattpilott commented Jun 24, 2020

Is your feature request related to a problem? Please describe.
I know its very early days, but currently node fails to install on macOS 10.16 installing via brew

Describe the solution you'd like
For node to work on 10.16, which of course naturally it will be, closer to release

Describe alternatives you've considered
The only alternate solution is to not use 10.16, which is totally fine, no pressure!

@devsnek devsnek added the macos Issues and PRs related to the macOS platform / OSX. label Jun 24, 2020
@devsnek
Copy link
Member

devsnek commented Jun 24, 2020

Related: nodejs/TSC#886

@devsnek devsnek changed the title Support macOS Big Sur (10.16) Support macOS Big Sur (10.16 / 11.0) Jun 24, 2020
@devsnek
Copy link
Member

devsnek commented Jun 24, 2020

@mcollina is it possible for us to get access to Big Sur preview?

@foxt
Copy link

foxt commented Jun 24, 2020

Installing Node 14.4.0 from Homebrew worked just fine on my MacBook. Also, I have the enrollment command, but i'm not sure if it'd be safe to post here.

@mattpilott
Copy link
Author

I installed the latest xcode tools and node now installs

@mcollina
Copy link
Member

@devsnek is it possible for us to get access to Big Sur preview?

Maybe. @rvagg do you think you can share some form of access to our developer account?

@rvagg
Copy link
Member

rvagg commented Jun 26, 2020

Screenshot 2020-06-26 19 50 58

@mcollina: Yeah, but I'm not sure what we're going to do with that. I don't think we want to be installing betas on our CI machines, that could get messy. I'm not sacrificing my machine for this upgrade, I only just bit the Catalina bullet and don't exactly trust Apple's recent track record on OS quality.

@AshCripps did we set up those MacMinis with VMWare Fusion? Is it worth the hassle installing and playing around with it? If you don't already have access to our Apple Developer team we should get you that, I think as a member of the team everyone gets access to this.

I know its very early days, but currently node fails to install on macOS 10.16 installing via brew

@matt3224 I think it would be best if you tried installing it directly. There's multiple steps between Node.js and you using Homebrew that could cause problems, and we're only responsible for a few of them. Just clone this repo, (optional: check out one of the stable branches, 14.x perhaps), run ./configure && make -j8 install and tell us if and how it fails.

@AshCripps
Copy link
Member

@rvagg Those macminis were set up with fusion so if you can get me an iso (or whatever apple gives you) I can set up a test machine. not 100% sure if it will require an update the the vmware itself and we may have to sacrifice a test machine (we have like 5 in total iirc so no issue).

I dont know if I have access to the developer team I never checked.

@rvagg
Copy link
Member

rvagg commented Jun 26, 2020

I don't know if it's worth your time or the sacrifice of a CI machine just to test things out this early. During these beta periods we normally rely on users submitting fixes or at least errors with enough information that we can figure it out. We're super early with Big Sur so I'm inclined to recommend we not spin our wheels this early. I'll get you set up in our Apple Developer team though so you can make a judgement for yourself, perhaps you're interested enough for personal reasons to have a poke at it!

@AshCripps
Copy link
Member

We've got some time anyway VMware Fusion isn't releasing a tech preview with big Sur support until next month anyway so we can't install it anywhere

@devsnek
Copy link
Member

devsnek commented Jun 26, 2020

@rvagg I'd be happy to help as well

@foxt
Copy link

foxt commented Jun 27, 2020

I'd be happy to help, however I don't know any thing about the Node codebase,but the download on Apple's Dev site only downloads a tool which enables the current machine upgrading to Big Sur. I don't know if you can download an ISO/DMG from Apple's site, if you can't i could possibly zip up a install media image?

@mattpilott
Copy link
Author

14.7.0 does not install though, just FYI

@mattpilott
Copy link
Author

After alot of testing it seems it will install if left long enough
Screenshot 2020-08-05 at 18 37 59

@billinghamj
Copy link

@matt3224 How did you get it to install with brew, given the openssl compilation issue and need for a patch?

@mattpilott
Copy link
Author

I removed brew entirely and all packages then installed brew and installed node, took ages but i now have node working ok

@claui
Copy link

claui commented Aug 10, 2020

@matt3224 Just to be perfectly clear, did you run your terminal app under Rosetta?

I don’t see how you could possibly have got this building without a patch under native Apple Silicon.

@mattpilott
Copy link
Author

Actually i'm running Intel, which explains the success

@billinghamj
Copy link

For anyone who's currently trying to use Node on a DTK, it should now work via brew - just update and install

@AshCripps
Copy link
Member

once #34238 lands we should have proper support for apple silicon

evanlucas added a commit to evanlucas/node that referenced this issue Aug 25, 2020
Ref: nodejs/TSC#886
Ref: nodejs#34043

PR-URL: nodejs#34238
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
richardlau pushed a commit that referenced this issue Sep 1, 2020
Ref: nodejs/TSC#886
Ref: #34043

PR-URL: #34238
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
Ref: nodejs/TSC#886
Ref: #34043

PR-URL: #34238
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
Ref: nodejs/TSC#886
Ref: #34043

PR-URL: #34238
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
@evanlucas
Copy link
Contributor

Node works on Big Sur and the master branch now fully works on Apple Silicon with #35415 and #34238 landed. Please feel free to let us know if there are any other issues. Thanks!

@andreialecu
Copy link

Sorry for pinging this old issue, but I didn't know how else to bring this to attention.

Recent RCs of Big Sur 11.2 broke node (on Apple Silicon at least), see #37061

My intention isn't to spam, but there hasn't been any acknowledgement in that thread that it is being looked into, and this is pretty serious as it completely blocks development (unless reverting to node 14 and rosetta).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Development

No branches or pull requests

10 participants