-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose SSL_export_keying_material via Node API (e.g. like SSL_get_shared_sigalgs) #31802
Comments
/cc @nodejs/crypto |
keylog is delivered from https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_keylog_callback.html, but if that isn't what you need exposing this new API seems reasonable. Care to take a shot at it? It seems you've already found the code it would be similar to. |
There's a mildly slippery slope here in that (I say "not really" because I think a |
@sam-github I tried my best, do you mind taking a look at it? :-) #31814 |
This way we'll know if and when the behavior changes. Right now, early data should not be sent because Node's built-in TLS server doesn't support it. Refs: nodejs#31802 (comment)
Fixes: #31802 PR-URL: #31814 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Fixes: nodejs#31802 PR-URL: nodejs#31814 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Fixes: #31802 PR-URL: #31814 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Is your feature request related to a problem? Please describe.
I'm trying to generate a check sum that is based on the keying material (https://stackoverflow.com/questions/60232165/ssl-export-keying-material-in-node-js). Right now node has no method to call this function, or any other way of retrieving this information.
Describe the solution you'd like
Expose an api like the GetSharedSigalgs that offers a way to access the native SSL export keying material method.
see https://nodejs.org/api/tls.html#tls_tlssocket_getsharedsigalgs
for the keying material method see https://www.openssl.org/docs/man1.0.2/man3/SSL_export_keying_material.html
Describe alternatives you've considered
I tried to get this kind of information via 'keylog' event, but this is never emitted in my scenario. I also believe (couldn't verify though), that this is something else than the exporting keying material function offers, due to the fact that I cannot provide any label to "keylog" which is mandatory for the keying material method.
Subsystem: tls (tls.TLSSocket)
The text was updated successfully, but these errors were encountered: