Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILDING.md says "make install --prefix=..." but that doesn't work #30477

Closed
cakoose opened this issue Nov 13, 2019 · 1 comment
Closed

BUILDING.md says "make install --prefix=..." but that doesn't work #30477

cakoose opened this issue Nov 13, 2019 · 1 comment

Comments

@cakoose
Copy link

cakoose commented Nov 13, 2019 •
edited
Loading

MacOS 10.14.6
GNU Make 3.81

BUILDING.md says:

make install --prefix=/opt/node-debug/

That resulted in an error:

/Applications/Xcode.app/Contents/Developer/usr/bin/make: unrecognized option `--prefix=/opt/node-debug/'
Usage: make [options] [target] ...
...

What did work for me:

./configure --prefix=...
make install
lpinca added a commit to lpinca/node that referenced this issue Nov 17, 2019
@lpinca
doc: fix overriding of prefix option
c6e73e5 
Make the example in the "Building a debug build" section work as
intended.

Fixes: nodejs#30477
@lpinca lpinca mentioned this issue Nov 17, 2019
Closed
3 tasks
@cakoose
Copy link
Author

cakoose commented Nov 21, 2019

Oh, nice! That's even more convenient than having to set the prefix during configure.

MylesBorins pushed a commit that referenced this issue Nov 21, 2019
@lpinca @MylesBorins
doc: fix overriding of prefix option
027bde5 
Make the example in the "Building a debug build" section work as
intended.

Fixes: #30477

PR-URL: #30518
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this issue Dec 1, 2019
@lpinca @targos
doc: fix overriding of prefix option
a992135 
Make the example in the "Building a debug build" section work as
intended.

Fixes: #30477

PR-URL: #30518
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this issue Dec 17, 2019
@lpinca @MylesBorins
doc: fix overriding of prefix option
a836ac1 
Make the example in the "Building a debug build" section work as
intended.

Fixes: #30477

PR-URL: #30518
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix overriding of prefix option lpinca/node
1 participant
@cakoose