-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access Violation #28773
Labels
Comments
This comment has been minimized.
This comment has been minimized.
3 tasks
#28788 should address this, thanks for reporting it! |
addaleax
added a commit
to addaleax/node
that referenced
this issue
Jul 21, 2019
Use the parent thread’s `ArrayBuffer::Allocator` when creating a Worker instance, as that allocator is guaranteed to outlive the Worker itself. This requires making the zero-fill flag a thread_local variable in order to avoid race conditions between different threads. A test for that behaviour is added as well. Fixes: nodejs#28777 Fixes: nodejs#28773
I found the the same problem,too. |
addaleax
added a commit
to addaleax/node
that referenced
this issue
Aug 17, 2019
Keep a reference to the `ArrayBuffer::Allocator` alive for at least as long as a `SharedArrayBuffer` allocated by it lives. Refs: nodejs#28788 Fixes: nodejs#28777 Fixes: nodejs#28773
3 tasks
targos
pushed a commit
that referenced
this issue
Aug 20, 2019
Keep a reference to the `ArrayBuffer::Allocator` alive for at least as long as a `SharedArrayBuffer` allocated by it lives. Refs: #28788 Fixes: #28777 Fixes: #28773 PR-URL: #29190 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
It is possible that I'm doing something wrong, but I believe the program should not crash.
By running the following code, the program crashes (most of the time) with C0000005.ACCESS_VIOLATION.
I've used
procdump64 -e node
to produce a dump file (available in the following zip file).node.exe_190719_222025.zip
Opening the dump file in Visual Studio, shows me this:
The text was updated successfully, but these errors were encountered: