Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky parallel/test-worker-debug on Windows #28106

Closed
sam-github opened this issue Jun 6, 2019 · 1 comment
Closed

Investigate flaky parallel/test-worker-debug on Windows #28106

sam-github opened this issue Jun 6, 2019 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@sam-github sam-github changed the title flaky: test-worker-debug on Windows Investigate flaky parallel/test-worker-debug on Windows Jun 6, 2019
@sam-github sam-github added flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. labels Jun 6, 2019
sam-github added a commit to sam-github/node that referenced this issue Jun 6, 2019
@refack
Copy link
Contributor

refack commented Jun 6, 2019

marking as flaky in #28035

addaleax added a commit to addaleax/node that referenced this issue Jun 19, 2019
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: nodejs#28299
Fixes: nodejs#28106
@danbev danbev closed this as completed in 2dec0f9 Jun 20, 2019
targos pushed a commit that referenced this issue Jul 2, 2019
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants