Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-worker-debug on Windows #28106

Closed
sam-github opened this issue Jun 6, 2019 · 1 comment
Closed

Investigate flaky parallel/test-worker-debug on Windows #28106

sam-github opened this issue Jun 6, 2019 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@sam-github
Copy link
Contributor

sam-github commented Jun 6, 2019 •
edited
Loading

It is the cause of most of the failures on https://ci.nodejs.org/job/node-test-binary-windows-2/:

etc...

@nodejs/platform-windows @nodejs/workers @Trott I guess I should PR to mark this test as flaky?

  • Version: master
  • Platform: Windows
  • Subsystem: workers
@sam-github sam-github changed the title flaky: test-worker-debug on Windows Investigate flaky parallel/test-worker-debug on Windows Jun 6, 2019
@sam-github sam-github added flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. labels Jun 6, 2019
sam-github added a commit to sam-github/node that referenced this issue Jun 6, 2019
@sam-github
test: mark test-worker-debug flaky
17de20e 
See: nodejs#28106
@sam-github sam-github mentioned this issue Jun 6, 2019
Closed
4 tasks
@refack
Copy link
Contributor

refack commented Jun 6, 2019 •
edited
Loading

marking as flaky in #28035

@Trott Trott mentioned this issue Jun 7, 2019
Closed
13 tasks
@Trott Trott mentioned this issue Jun 18, 2019
Closed
@sam-github sam-github mentioned this issue Jun 19, 2019
Closed
addaleax added a commit to addaleax/node that referenced this issue Jun 19, 2019
@addaleax
test: fix flaky test-worker-debug
441fc92 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: nodejs#28299
Fixes: nodejs#28106
@addaleax addaleax mentioned this issue Jun 19, 2019
Closed
3 tasks
@danbev danbev closed this as completed in 2dec0f9 Jun 20, 2019
targos pushed a commit that referenced this issue Jul 2, 2019
@addaleax @targos
test: fix flaky test-worker-debug
c44db7f 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-worker-debug addaleax/node
2 participants
@sam-github @refack