-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic: Start menu item installed by Node 12 uses old/outdated node icon #27934
Comments
Ref to file history https://github.com/nodejs/node/commits/master/src/res/node.ico |
Using the JS hexagon instead: Both are produced from the SVG on the node website, with the other resources removed, and then converted using https://icoconvert.com/ |
I'm +1 on the green gem. But I love that the old one is 3D. But2 I'm not sure the 3D look is OpenJSF blessed. |
I've made a poll on Twitter - please vote there! https://twitter.com/mikemaccana/status/1133393051328679939 |
Thanks @refack I'll make sure they're all there. What tool are you using to inspect it? |
Surprisingly (at least to me) the best one I found already installed on my computer is MSVS. But I had success with a several googlable tools in the past, if I remember correctly |
Hexagon source file is here: https://github.com/nodejs/nodejs.org/blob/master/static/images/logo-hexagon.svg There's also a 32px PNG: https://github.com/nodejs/nodejs.org/blob/master/static/favicon.png |
it's the old green gem on my windows. but I like the new one |
Updated the Windows icon for the fixed hexagon svg per nodejs/nodejs.org#2316 Process (just in case this needs to be repeated)
|
PR-URL: #28524 Fixes: #27934 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #28524 Fixes: #27934 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Start menu item installed by Node 12 uses old/outdated node icon (last updated Aug 2015):
It should look more like this image (per current branding from Feb 2016):
The text was updated successfully, but these errors were encountered: