Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-net-server-max-connections #2663

Closed
joaocgreis opened this issue Sep 2, 2015 · 7 comments
Closed

Investigate flaky test test-net-server-max-connections #2663

joaocgreis opened this issue Sep 2, 2015 · 7 comments
Labels
build Issues and PRs related to build files or the CI. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@joaocgreis
Copy link
Member

Examples of failures:
@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Sep 2, 2015
@joaocgreis joaocgreis mentioned this issue Sep 2, 2015
Closed
joaocgreis added a commit to JaneaSystems/node that referenced this issue Sep 3, 2015
@joaocgreis @orangemocha
test: test-net-server-max-connections is flaky
11a29c4 
Ref: nodejs#2663
@whitlockjc
Copy link
Contributor

I can reproduce this on SmartOS. I'll investigate but what about a smartos label? I ask only because this test is not flaky on OS X or Ubuntu.

@joaocgreis joaocgreis added the smartos Issues and PRs related to the SmartOS platform. label Oct 22, 2015
@whitlockjc
Copy link
Contributor

I guess solaris would be better. ;) Thanks for the label.

@Trott
Copy link
Member

Trott commented Nov 1, 2015

The last time this test failed again on smartos14-32 was a bit over two weeks ago on October 16: https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos14-32/15/tapTestReport/test.tap-538/. That's not so long ago as for me to think we should remove its flaky status, but it is long enough ago that I suspect we should keep an eye on it. By the way, that's the only time smartos14-32 failed with this test since moving out of node-test-commit-other and moving into node-test-commit-smartos.

@Trott
Copy link
Member

Trott commented Nov 1, 2015

Darn. I submitted a job to run that test 1000 times on smartos14-32 and sure enough, it failed a handful of times. https://ci.nodejs.org/job/node-test-commit-smartos/189/nodes=smartos14-32/console

@whitlockjc
Copy link
Contributor

That's how many iterations my test run was for.

@Trott
Copy link
Member

Trott commented Nov 14, 2015

Possibly related? https://smartos.org/bugview/OS-2767

Trott added a commit to Trott/io.js that referenced this issue Nov 15, 2015
@Trott
test: fix flaky SmartOS test
ed38d05 
SmartOS has an issue where it will trigger ECONNREFUSED when it should
not. See https://smartos.org/bugview/OS-2767.

This change adds logic to test-net-server-max-connections.js to work
around the issue.

Fixes: nodejs#2663
@Trott Trott mentioned this issue Nov 15, 2015
Closed
@Trott
Copy link
Member

Trott commented Nov 15, 2015

I believe #3830 will fix this.

@Trott Trott closed this as completed in 5b80ca9 Nov 16, 2015
Trott added a commit that referenced this issue Nov 17, 2015
@Trott @Fishrock123
test: fix flaky SmartOS test
19a36ff 
SmartOS has an issue where it will trigger ECONNREFUSED when it should
not. See https://smartos.org/bugview/OS-2767.

This change adds logic to test-net-server-max-connections.js to work
around the issue.

Fixes: #2663
PR-URL: #3830
Reviewed-By: James M Snell <[email protected]>
@claudiorodriguez claudiorodriguez mentioned this issue Nov 18, 2015
Closed
claudiorodriguez pushed a commit to claudiorodriguez/node that referenced this issue Nov 19, 2015
test: fix flaky http-chunked-304 on smartos
89d67c3 
SmartOS has an issue where it will trigger ECONNREFUSED when it
should not. See https://smartos.org/bugview/OS-2767.

This change adds logic to test-http-chunked-304 to work around
the issue. See also similar issue: nodejs#2663

Fixes: nodejs#3864
Trott added a commit that referenced this issue Nov 30, 2015
@Trott
test: fix flaky SmartOS test
2d39141 
SmartOS has an issue where it will trigger ECONNREFUSED when it should
not. See https://smartos.org/bugview/OS-2767.

This change adds logic to test-net-server-max-connections.js to work
around the issue.

Fixes: #2663
PR-URL: #3830
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this issue Dec 4, 2015
@Trott @rvagg
test: fix flaky SmartOS test
93b3a37 
SmartOS has an issue where it will trigger ECONNREFUSED when it should
not. See https://smartos.org/bugview/OS-2767.

This change adds logic to test-net-server-max-connections.js to work
around the issue.

Fixes: #2663
PR-URL: #3830
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this issue Dec 17, 2015
@Trott @jasnell
test: fix flaky SmartOS test
150f126 
SmartOS has an issue where it will trigger ECONNREFUSED when it should
not. See https://smartos.org/bugview/OS-2767.

This change adds logic to test-net-server-max-connections.js to work
around the issue.

Fixes: #2663
PR-URL: #3830
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this issue Dec 23, 2015
@Trott @jasnell
test: fix flaky SmartOS test
7d569b3 
SmartOS has an issue where it will trigger ECONNREFUSED when it should
not. See https://smartos.org/bugview/OS-2767.

This change adds logic to test-net-server-max-connections.js to work
around the issue.

Fixes: #2663
PR-URL: #3830
Reviewed-By: James M Snell <[email protected]>
@mkrawczuk mkrawczuk mentioned this issue Jun 27, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whitlockjc @joaocgreis @Trott