Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Dirent definition doesn't tell me anything useful about Dirent #25595

Closed
mmmeff opened this issue Jan 20, 2019 · 6 comments
Closed

docs: Dirent definition doesn't tell me anything useful about Dirent #25595

mmmeff opened this issue Jan 20, 2019 · 6 comments
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Comments

@mmmeff
Copy link

mmmeff commented Jan 20, 2019

Link: https://nodejs.org/api/fs.html#fs_class_fs_dirent

After clicking the link to this definition from the fs section on readDir, it seems circular and not at all helpful. After reading the definition, I still have no idea what a Dirent is.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jan 20, 2019

There are some dirent.* methods and properties of class instances just below the class description, are they of any help?

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jan 20, 2019
@cjihrig
Copy link
Contributor

cjihrig commented Jan 20, 2019

Would the documentation be more useful if it contained the words "directory entry"?

@mmmeff
Copy link
Author

mmmeff commented Jan 21, 2019

@vsemozhetbyt I don't think the best way to explain a concept to someone reading documentation is to leave it up for interpretation based on the API.

@cjihrig Sure, and perhaps also a definition for what a "directory entry" is.

@gireeshpunathil gireeshpunathil added the good first issue Issues that are suitable for first-time contributors. label Jan 5, 2020
@manisaiprasad
Copy link

@mmmeff Directory Entry is basically the mapping of the filename to its inode, the inode contains all the data of the file except its name and the actual data in the file

if no one is working on this I can give a try

el5846 pushed a commit to el5846/node that referenced this issue Apr 14, 2020
Fixes: nodejs#25595

subdirectory

updated def
@HassanRazaMuhammadTufail

Is this issue solved?

@addaleax
Copy link
Member

@HassanRazaMuhammadTufail There is #32791, which will fix this issue – I’ll remove the good first issue label here for clarity :)

@addaleax addaleax removed the good first issue Issues that are suitable for first-time contributors. label Apr 17, 2020
BethGriggs pushed a commit that referenced this issue Apr 27, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR pushed a commit that referenced this issue Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR pushed a commit that referenced this issue Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this issue Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this issue Apr 30, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this issue May 13, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants