Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure on Windows #25096

Closed
gabrielschulhof opened this issue Dec 17, 2018 · 4 comments
Closed

Build failure on Windows #25096

gabrielschulhof opened this issue Dec 17, 2018 · 4 comments
Labels
module Issues and PRs related to the module subsystem. windows Issues and PRs related to the Windows platform.

Comments

@gabrielschulhof
Copy link
Contributor

While running vcbuild.bat test-addons:

Building addons
internal/modules/cjs/loader.js:602
    throw err;
    ^

Error: Cannot find module 'to-vfile'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:600:15)
    at Function.Module._load (internal/modules/cjs/loader.js:529:25)
    at Module.require (internal/modules/cjs/loader.js:654:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (C:\Users\agnes\code\node\tools\doc\addon-verify.js:11:15)
    at Module._compile (internal/modules/cjs/loader.js:718:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)
    at Module.load (internal/modules/cjs/loader.js:617:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
@gabrielschulhof gabrielschulhof added module Issues and PRs related to the module subsystem. windows Issues and PRs related to the Windows platform. labels Dec 17, 2018
@Trott
Copy link
Member

Trott commented Dec 18, 2018

@nodejs/build @nodejs/platform-windows

@bzoz
Copy link
Contributor

bzoz commented Dec 18, 2018

Can reproduce. Clean master checkout fails to build addons.

bzoz added a commit to JaneaSystems/node that referenced this issue Dec 18, 2018
@bzoz
win, build: fix building addons on Windows
64d5574 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: nodejs#25096
@bzoz bzoz mentioned this issue Dec 18, 2018
Closed
2 tasks
@bzoz
Copy link
Contributor

bzoz commented Dec 18, 2018

Fix in #25108

@gengjiawen
Copy link
Member

Any thought introduce appveyor to prevent future regression ?

targos pushed a commit that referenced this issue Jan 1, 2019
@bzoz @targos
win, build: fix building addons on Windows
2df0d14 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <[email protected]>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@bzoz @refack
win, build: fix building addons on Windows
f23139f 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: nodejs#25096

PR-URL: nodejs#25108
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this issue Apr 28, 2019
@bzoz @BethGriggs
win, build: fix building addons on Windows
9af9ee5 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this issue May 10, 2019
@bzoz @BethGriggs
win, build: fix building addons on Windows
979a397 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue May 16, 2019
@bzoz @MylesBorins
win, build: fix building addons on Windows
91c4d28 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module Issues and PRs related to the module subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

win, build: fix building addons on Windows JaneaSystems/node
4 participants
@Trott @gabrielschulhof @gengjiawen @bzoz