Lost /deps/cares/src/ares_android.h

[kelp404]

• Version: 10.12.0
• Platform:
  Target: Android-21
  Host: Ubuntu 16.04
• Subsystem:
  NDK: 17

Hello,
I want to build node.js for Android.
But I can't build successful because of no /deps/cares/src/ares_android.h.

ares_android.h is in cares-1_14_0 release.
https://github.com/c-ares/c-ares/blob/cares-1_14_0/ares_android.h

ares_android.h didn't add into node project. https://github.com/nodejs/node/tree/v10.x/deps/cares/src
We just add ares_android.c at this commit b82f905.

../deps/cares/config/android/ares_config.h:62:1: warning: (this will be reported only once per input file)
../deps/cares/src/ares_android.c:21:26: fatal error: ares_android.h: No such file or directory
 #include "ares_android.h"
                          ^
compilation terminated.
deps/cares/cares.target.mk:143: recipe for target '/builds/cloud/node/out/Release/obj.target/cares/deps/cares/src/ares_android.o' failed
make[1]: *** [/builds/cloud/node/out/Release/obj.target/cares/deps/cares/src/ares_android.o] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:99: recipe for target 'node' failed
make: *** [node] Error 2

[cjihrig]

Does #23682 fix things?

[kelp404]

Hello @cjihrig ,
Thank you.
This issue was fixed.