sequential/test-repl-persistent-history is failing on OS X

[evanlucas]

Path: sequential/test-repl-persistent-history
assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: '> \'=^.^=\'' === '> \'42\''
    at Writable.write [as _write] (/Users/evan/dev/code/forks/io.js/test/sequential/test-repl-persistent-history.js:173:16)
    at doWrite (_stream_writable.js:292:12)
    at writeOrBuffer (_stream_writable.js:278:5)
    at Writable.write (_stream_writable.js:207:11)
    at REPLServer._writeToOutput (readline.js:219:17)
    at REPLServer.Interface._refreshLine (readline.js:259:8)
    at REPLServer.Interface._historyPrev (readline.js:572:10)
    at REPLServer.Interface._ttyWrite (readline.js:858:14)
    at ActionStream.onkeypress (readline.js:105:10)
    at emitTwo (events.js:87:13)

I haven't tested it on any other OS for now.

[Fishrock123]

On the CI? If so, can you point me to a CI run?

I really need to update that test so it shows which set of tests actually failed the assertion...

[evanlucas]

Weird, it seems fine on the CI. I can't get it to pass locally though on OS X 10.10.4

[evanlucas]

It seems to pass locally for me about every 1 in 15 times

[Fishrock123]

@evanlucas what's your OS X version? Also, is this on master?

[evanlucas]

Yes. 10.10.4

[targos]

I just ran the test 5 times on the same OS X and got no error

[evanlucas]

very strange, I can hardly get it to pass

[thefourtheye]

Can you comment out that particular case and try?

[Fishrock123]

Can you comment out that particular case and try?

Ok so, the (other) problem here is that figuring out which case is having problems isn't necessarily easy. (I guess I should log some more info in the tests...?) :/

@evanlucas I think the problem is that the test isn't writing to the history file correctly?

Can you run it just as ./iojs --expose-internals test/sequential/test-repl-persistent-history.js and then post what is in test/tmp/.node_repl_history?

[jbergstroem]

Have a look at your permissions/ownership; perhaps you've previously run tests as another user? Does the sudo sandwich work? (sudo make test)

[evanlucas]

It will be this afternoon before I can test again on that machine. It works fine on my laptop. :/

[evanlucas]

It looks like it is a race condition. The history file does not appear to be completely written.

The contents of that file:

'=^.^='
'hello world'

The patch below seems to work reliably for me. It's unfortunate that it takes using setTimeout though.

diff --git a/test/sequential/test-repl-persistent-history.js b/test/sequential/test-repl-persistent-history.js
index 8d550f6..9298269 100644
--- a/test/sequential/test-repl-persistent-history.js
+++ b/test/sequential/test-repl-persistent-history.js
@@ -185,7 +185,7 @@ function runTest() {
     repl.on('close', function() {
       // Ensure everything that we expected was output
       assert.strictEqual(expected.length, 0);
-      setImmediate(runTest);
+      setTimeout(runTest, 5);
     });

     repl.inputStream.run(test);

[Fishrock123]

The patch below seems to work reliably for me. It's unfortunate that it takes using setTimeout though.

Can you try uncommenting this: https://github.com/nodejs/node/blob/master/test/sequential/test-repl-persistent-history.js#L109-L113 (I forgot to remove the comment oops, fixed in #2358)

[joaocgreis]

As it is in the current master, this test fails every time on my local Ubuntu 14.04 and I got it to fail after 336 runs on Windows 2012r2.

[Fishrock123]

#2356 Fixes this but I haven't been able to resolve windows EPERM errors.