Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repl eval() with context ignored in 10.2.0+ #20965

Closed
jdalton opened this issue May 25, 2018 · 3 comments
Closed

Repl eval() with context ignored in 10.2.0+ #20965

jdalton opened this issue May 25, 2018 · 3 comments
Labels
regression Issues related to regressions. repl Issues and PRs related to the REPL subsystem.

Comments

@jdalton
Copy link
Member

jdalton commented May 25, 2018 •
edited
Loading

The commit here 9aa4ec4 has caused default repl#eval to ignore the context parameter passed to it. The issue was introduced in PR #20617 (issue #19021).
@addaleax addaleax added repl Issues and PRs related to the REPL subsystem. regression Issues related to regressions. labels May 25, 2018
@addaleax
Copy link
Member

I’d just revert the patch for now. Thoughts?

@jdalton
Copy link
Member Author

jdalton commented May 25, 2018

IMO since the bit reverted would be just extra hints a revert would be ok.
Then it could be retooled and merged at a later time.

@cjihrig cjihrig mentioned this issue May 26, 2018
Merged
cjihrig added a commit to cjihrig/node that referenced this issue May 28, 2018
@cjihrig
Revert "repl: add friendly tips about how to exit repl"
4dbfb09 
This reverts commit 9aa4ec4.

This commit in question introduced a regression in repl.eval(),
as the context argument is no longer passed to runInContext().

PR-URL: nodejs#20972
Fixes: nodejs#20965
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
@jdalton
Copy link
Member Author

jdalton commented May 28, 2018

Thank you @cjihrig!

MylesBorins pushed a commit that referenced this issue May 29, 2018
@cjihrig @MylesBorins
Revert "repl: add friendly tips about how to exit repl"
5f9c01b 
This reverts commit 9aa4ec4.

This commit in question introduced a regression in repl.eval(),
as the context argument is no longer passed to runInContext().

PR-URL: #20972
Fixes: #20965
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Issues related to regressions. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @addaleax