-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSD-x86 config missing after OpenSSL 1.1.0h import #20326
Comments
Want to submit a pull request? I have no way to test so I'd be committing blindly if I just checked in the file. |
Yes, I do, but unfortunately |
Is this still an issue? (I'm guessing yes, but it's been inactive long enough that maybe it got fixed but the issue was never closed?) |
Yes, it is still an issue. The FreeBSD port/package patches the build to use a no-asm build on i386 as a workaround. I have yet to invest the time in a proper solution. |
You know, I'd be okay with adding BSD-x86 to the list and just regenerating everything. It's not a supported platform so if it works, cool, and if it doesn't, it's not a regression. |
Add BSD-x86 to the list of arches and regenerate everything. Everything in deps/openssl/config/archs/BSD-x86 is auto-generated, everything else is manual edits to include the right files in the right places. I cheated a little: I didn't check in changes to files for other arches because they contained mostly churn (updated buildstamps and such.) Fixes: nodejs#20326
@bradleythughes Perhaps you can test #28806? |
Add BSD-x86 to the list of arches and regenerate everything. Everything in deps/openssl/config/archs/BSD-x86 is auto-generated, everything else is manual edits to include the right files in the right places. I cheated a little: I didn't check in changes to files for other arches because they contained mostly churn (updated buildstamps and such.) Fixes: #20326 PR-URL: #28806 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
After the OpenSSL 1.1.0h import,
deps/openssl/config/Makefile
was added with a list of supported architectures for building with ASM support. However, the ARCHS list (errantly?) omits BSD-x86 from the list:https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/config/Makefile#L12
The BSD-x86 arch is listed in the README and header files, however, and trying to build Node.js v10.0.0 on FreeBSD i386 fails due to the missing BSD-x86/* headers.
https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/README.md
https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/config/opensslconf_asm.h#L39
https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/config/opensslconf_asm.h#L112
https://github.com/nodejs/node/blob/v10.0.0/deps/openssl/config/opensslconf_no-asm.h#L20
The text was updated successfully, but these errors were encountered: