Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark StackOverflow as unofficial #19412

Closed
fhinkel opened this issue Mar 17, 2018 · 7 comments
Closed

doc: mark StackOverflow as unofficial #19412

fhinkel opened this issue Mar 17, 2018 · 7 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@fhinkel
Copy link
Member

fhinkel commented Mar 17, 2018

We're listing StackOverflow as a place for support in our README.md. Following the discussion in #18191, we should make it clear that the StackOverflow entries are not moderated by the Node.js Foundation.
@fhinkel fhinkel added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Mar 17, 2018
@ckotzbauer
Copy link

@fhinkel Can I pick this up?

@JosephLeon
Copy link
Contributor

I tried pushing up a fix for this but I'm getting:

remote: Permission to nodejs/node.git denied to JosephLeon.
fatal: unable to access 'https://github.com/nodejs/node.git/': The requested URL returned error: 403

@devsnek
Copy link
Member

devsnek commented Mar 17, 2018

@JosephLeon you'll have to open a pr, check out https://github.com/nodejs/node/blob/master/CONTRIBUTING.md

@JosephLeon
Copy link
Contributor

Ok, got a PR up here #19416

@fhinkel
Copy link
Member Author

fhinkel commented Mar 19, 2018

@JosephLeon Thanks for picking this up!

@code-chris sorry I didn't see your response early enough 😞

@ckotzbauer
Copy link

@fhinkel No problem 😉

@Trott
Copy link
Member

Trott commented Mar 19, 2018

Removing good first contribution on this since there's an open PR for it. #19416

@Trott Trott removed the good first issue Issues that are suitable for first-time contributors. label Mar 19, 2018
@Trott Trott mentioned this issue Mar 19, 2018
Closed
2 tasks
Trott pushed a commit to JosephLeon/node that referenced this issue Mar 22, 2018
@JosephLeon @Trott
doc: move StackOverflow to unofficial section
2d12cdd 
Fixes: nodejs#19412
@Trott Trott closed this as completed in 258bcb9 Mar 22, 2018
targos pushed a commit that referenced this issue Mar 24, 2018
@JosephLeon @targos
doc: move StackOverflow to unofficial section
e9f41ee 
Fixes: #19412

PR-URL: #19416
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this issue Dec 3, 2018
@JosephLeon @BethGriggs
doc: move StackOverflow to unofficial section
4db289c 
Fixes: #19412

PR-URL: #19416
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fhinkel @Trott @JosephLeon @devsnek @ckotzbauer