Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test-cluster-worker-wait-server-close.js is hanging #1933

Closed
Olegas opened this issue Jun 10, 2015 · 2 comments
Closed

test: test-cluster-worker-wait-server-close.js is hanging #1933

Olegas opened this issue Jun 10, 2015 · 2 comments
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

Comments

@Olegas
Copy link
Contributor

Olegas commented Jun 10, 2015

Relates to #1400
Prevents testing at least at #1896
@Olegas Olegas added the test Issues and PRs related to the tests. label Jun 10, 2015
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Jun 10, 2015
@Olegas Olegas mentioned this issue Jun 10, 2015
Closed
Olegas added a commit to Olegas/io.js that referenced this issue Jun 11, 2015
@Olegas
cluster: fix broken/hanging tests
c2b44a4 
Fixes: nodejs#1933
@sam-github sam-github mentioned this issue Jun 11, 2015
Closed
@sam-github
Copy link
Contributor

should be fixed by #1953

@Olegas Olegas reopened this Jun 12, 2015
sam-github added a commit that referenced this issue Jun 12, 2015
@sam-github
test: fix cluster-worker-wait-server-close races
03ce84d 
Wait for data to arrive from worker before doing a disconnect. Without
this, whether the disconnect arrives at the worker before the master
accepts and forwards the connection descriptor to the worker is a race.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
PR-URL: #1953
Fixes: #1933
Fixes: #1400
@sam-github
Copy link
Contributor

Re-landed on the correct branch: #1953 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix cluster test for disconnect with open connections sam-github/node
3 participants
@sam-github @mscdex @Olegas