-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md improvements #17842
Labels
doc
Issues and PRs related to the documentations.
feature request
Issues that request new features to be added to Node.js.
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
Comments
Trott
added
doc
Issues and PRs related to the documentations.
feature request
Issues that request new features to be added to Node.js.
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
labels
Dec 23, 2017
3 tasks
Big +1 to simplifying CONTRIBUTING.md and listing links there instead of leaving a wall of text. I would say the same should be done to COLLABORATOR_GUIDE.md as well, there are a few overlaps in those two guides, we can merge those in one document and link to that in both guides. |
@joyeecheung and @Trott I can take this up. |
2 tasks
evanlucas
pushed a commit
that referenced
this issue
Jan 30, 2018
PR-URL: #18271 Fixes: #17842 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Feb 27, 2018
PR-URL: #18271 Fixes: #17842 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
PR-URL: nodejs#18271 Fixes: nodejs#17842 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
feature request
Issues that request new features to be added to Node.js.
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
A problem with our
CONTRIBUTING.md
is that it is very long and is often needlessly wordy.Most people who are reading the doc are probably clicking through to it from the interface where they are opening a pull request or an issue.
In other words, they are just about to do something. That is a terrible time to put a super long document in front of them. Ideally, it would be a short document with just what people need.
Unfortunately, that can be in tension with other purposes/uses of
CONTRIBUTING.md
such as to advertise our values and be welcoming. So, removing content might hit objections.I had intended to go through and make it more concise in a piecemeal fashion without eliminating content. See 90abfd6 for example. But then…
I went to open a pull request in ESLint and came across this magnificent example of a
CONTRIBUTING.md
.Nice and short, but links out to the things you need to know. If you're opening a bug report it doesn't put hundreds of words about change requests in front of you. That sort of thing.
So, if someone wants to try to re-organize our
CONTRIBUTING.md
to be more like that one, I'd be 👍. Necessary caveat: There are 106 other Collaborators on Node.js and they are likely to have opinions too and their opinions may contradict mine or each other's. Doc changes are hard enough as is, but do be prepared for the too-many-cooks problem. Don't get discouraged!The text was updated successfully, but these errors were encountered: