Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-listen-fd-ebadf #17762

Closed
gibfahn opened this issue Dec 19, 2017 · 3 comments
Closed

Investigate flaky parallel/test-listen-fd-ebadf #17762

gibfahn opened this issue Dec 19, 2017 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@gibfahn
Copy link
Member

gibfahn commented Dec 19, 2017

  • Version: v8.x
  • Platform: Linux
  • Subsystem: test
=== release test-listen-fd-ebadf ===                                           
Path: parallel/test-listen-fd-ebadf
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 'ENOTSOCK' === 'EINVAL'
    at Server.onError (/build/gib/node/test/parallel/test-listen-fd-ebadf.js:33:10)
    at Server.<anonymous> (/build/gib/node/test/common/index.js:533:15)
    at emitOne (events.js:116:13)
    at Server.emit (events.js:211:7)
    at emitErrorNT (net.js:1383:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
    at Function.Module.runMain (module.js:678:11)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3
Command: out/Release/node /build/gib/node/test/parallel/test-listen-fd-ebadf.js

Looks like it also failed in #15338 (comment) and #8895 (comment)
@gibfahn gibfahn added flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. labels Dec 19, 2017
@Trott
Copy link
Member

Trott commented Dec 19, 2017

@gibfahn Can you provide a link to CI? Even though they go stale quickly, they're still useful to know exactly what platform is involved, especially for things like this that are on "Linux"....

@gibfahn
Copy link
Member Author

gibfahn commented Dec 20, 2017 •
edited
Loading

@gibfahn Can you provide a link to CI? Even though they go stale quickly, they're still useful to know exactly what platform is involved, especially for things like this that are on "Linux"....

It was on my local machine. It's a Rhel 7.2 x64 box. The linked comments were to CI failures though...

@Trott Trott mentioned this issue Dec 20, 2017
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Dec 20, 2017

Proposed fix in #17797

Trott added a commit to Trott/io.js that referenced this issue Dec 20, 2017
@Trott
test: improve flaky test-listen-fd-ebadf.js
b3c4365 
Find an invalid file descriptor rather than assuming 42 will be invalid.

Fixes: nodejs#17762
@Trott Trott closed this as completed in 1d87891 Dec 21, 2017
MylesBorins pushed a commit that referenced this issue Jan 8, 2018
@Trott @MylesBorins
test: improve flaky test-listen-fd-ebadf.js
d40e631 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@Trott @MylesBorins
test: improve flaky test-listen-fd-ebadf.js
fdbf951 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@Trott @MylesBorins
test: improve flaky test-listen-fd-ebadf.js
112b655 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
gibfahn pushed a commit that referenced this issue Jan 24, 2018
@Trott @gibfahn
test: improve flaky test-listen-fd-ebadf.js
69944e3 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
gibfahn pushed a commit that referenced this issue Jan 24, 2018
@Trott @gibfahn
test: improve flaky test-listen-fd-ebadf.js
8c5fe7b 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott added a commit to Trott/io.js that referenced this issue Jan 25, 2018
@Trott
test: improve flaky test-listen-fd-ebadf.js
9321f6a 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: nodejs#17797
Fixes: nodejs#17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott Trott mentioned this issue Jan 25, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this issue Feb 5, 2018
@Trott @MylesBorins
test: improve flaky test-listen-fd-ebadf.js
b6a2b6e 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 11, 2018
@Trott @MylesBorins
test: improve flaky test-listen-fd-ebadf.js
bce5a62 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 12, 2018
@Trott @MylesBorins
test: improve flaky test-listen-fd-ebadf.js
f70d6ed 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 13, 2018
@Trott @MylesBorins
test: improve flaky test-listen-fd-ebadf.js
5668403 
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve flaky test-listen-fd-ebadf.js Trott/io.js
2 participants
@Trott @gibfahn