-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow wildcard match in util.debuglog() #17605
Labels
feature request
Issues that request new features to be added to Node.js.
util
Issues and PRs related to the built-in util module.
Comments
vsemozhetbyt
added
feature request
Issues that request new features to be added to Node.js.
util
Issues and PRs related to the built-in util module.
labels
Dec 11, 2017
targos
added a commit
to targos/node
that referenced
this issue
Dec 11, 2017
4 tasks
Thanks for opening this issue! This is something I always wanted to have :) |
@targos Oh thx, I just finish my implementation also. Should I propose mine or make some changes on your codebase? |
Oh sure, go ahead and open a PR with yours 😉 |
@targos thx : ) |
4 tasks
MylesBorins
pushed a commit
that referenced
this issue
Jan 8, 2018
PR-URL: #17609 Fixes: #17605 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature request
Issues that request new features to be added to Node.js.
util
Issues and PRs related to the built-in util module.
Refs: #13728
Currently,
util.debuglog()
doesn't support wildcard. It will be more dev friendly if it could.Consider the structure below,
we might have different files in the same module, and we really don't want to output those logs at the same time.
So a possible solution could be, we define a prefix/postfix to the same module, e.g.
util.debuglog('classifiers-logical-regressions')
,util.debuglog('classifiers-linear-regression')
Then we could define the NODE_DEBUG below to output
*-regressions
only logs, would belogical-regression
andlinear-regression
in this case.Please feel free to add more comments.
The text was updated successfully, but these errors were encountered: