Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: how to use advanced features of configure on Windows #17331

Closed
refack opened this issue Nov 26, 2017 · 11 comments
Closed

doc: how to use advanced features of configure on Windows #17331

refack opened this issue Nov 26, 2017 · 11 comments
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform. wip Issues and PRs that are still a work in progress.

Comments

@refack
Copy link
Contributor

refack commented Nov 26, 2017 •
edited
Loading

Refs: #17066

The configure script recognizes many CLI flags for special build formulas. Many are not represented by vcbuild shortcuts, and need to be passed either by:

  • Calling python configure --XXX --YYY=PPPP directly, followed by vcbuild noprojgen
  • Setting set config_flags=--XXX --YYY=PPPP before calling vcbuild

This should be documented.
@refack refack added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. windows Issues and PRs related to the Windows platform. labels Nov 26, 2017
@ghost
Copy link

ghost commented Dec 15, 2017

Can I take this up?

@joyeecheung
Copy link
Member

@lazyspark Sure! The contributing guide should be enough to help you get started.

@juggernaut451
Copy link
Contributor

@lazyspark if you are not working on this.. can i take this up? @joyeecheung @refack

@ghost
Copy link

ghost commented Feb 14, 2018

Yes please.

@jake32321
Copy link

Hey @juggernaut451 are you still working on this? If not, I could try and take a shot if you don't have the time. Don't want this to change hands too many times but would love to take a crack at this if you don't mind.

@refack
Copy link
Contributor Author

refack commented Jun 11, 2018

I was thinking about this today and had the idea of calling python configure --help as part of the help subrutine in vcbuild.bat

@jake32321
Copy link

@refack yeah that should be simple enough to make that addition.

@rexagod
Copy link
Member

rexagod commented Jun 4, 2019

@refack @jake32321 Can I take this up? Thanks!

@refack
Copy link
Contributor Author

refack commented Jun 4, 2019

Hello @rexagod, and thanks for the offer.
AFAICT this issue is available for "adoption", so I'd be very grateful if you take this up.

If you haven't already, it's recommended you take a look at CONTRIBUTING.md
Anyway thank you for the contribution, and good luck 🥇

P.S. If you have any questions feel free to contact me directly.

@refack refack added wip Issues and PRs that are still a work in progress. and removed good first issue Issues that are suitable for first-time contributors. labels Jun 4, 2019
@rexagod
Copy link
Member

rexagod commented Jun 5, 2019

@refack Thank you for the quick response! Apologies if it takes me a while to wrap my head around this, but you may be assured, I'm working on this. Also, I'll definitely contact you if any confusion arises, and again, thank you so much for the warm welcome! 👍

@rexagod rexagod mentioned this issue Jun 5, 2019
Closed
2 tasks
@rexagod
Copy link
Member

rexagod commented Jun 5, 2019

@refack Hi! I've made some changes and submitted a PR! Can you take a look? Thanks!

rexagod added a commit to rexagod/node that referenced this issue Jun 7, 2019
@rexagod
doc: add unrepresented flags docs for configure
cd3c32d 
added documentation to support usage of
advanced features of `configure` on Windows

Fixes: nodejs#17331
BridgeAR pushed a commit that referenced this issue Jan 3, 2020
@rexagod @BridgeAR
doc: add unrepresented flags docs for configure
4caf457 
Added documentation to support usage of advanced features of
`configure` on Windows.

PR-URL: #28069
Fixes: #17331
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this issue Jan 14, 2020
@rexagod @targos
doc: add unrepresented flags docs for configure
bbb5707 
Added documentation to support usage of advanced features of
`configure` on Windows.

PR-URL: #28069
Fixes: #17331
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@rexagod @BethGriggs
doc: add unrepresented flags docs for configure
7b567bd 
Added documentation to support usage of advanced features of
`configure` on Windows.

PR-URL: #28069
Fixes: #17331
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add unrepresented flags docs for configure rexagod/node
6 participants
@refack @joyeecheung @juggernaut451 @jake32321 @rexagod and others